Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make successful reset of Rewards data also reset onboarding state #12877

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 4, 2022

Resolves brave/brave-browser#22003

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Enable Rewards
  • Visit brave://rewards
  • Reset Rewards via "Manage Brave Rewards" button
  • Ensure that onboarding overlay displays on brave://rewards
  • Ensure that onboarding overlay displays on Rewards panel

@emerick emerick requested a review from a team as a code owner April 4, 2022 18:26
@emerick emerick self-assigned this Apr 4, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 4, 2022
@emerick emerick force-pushed the rewards-reset-onboarding branch 2 times, most recently from 7fac2dc to 3b42ace Compare April 4, 2022 19:09
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick removed the request for review from deeppandya April 4, 2022 23:51
Comment on lines +456 to +457
onboardingCompletedStore.clear()
chrome.send('brave_rewards.getOnboardingStatus')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make this change to components/brave_rewards/resources/android_page/reducers/rewards_reducer.ts as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have it in there initially, but there's no onboarding overlay on the Android settings page. Maybe I should add it to the reducer anyway for consistency though? WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd probably still add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed. I added that in and a couple of missing onboarding-related case statements to bring the android page in line with the desktop page.

@emerick emerick requested a review from zenparsing April 5, 2022 10:47
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick
Copy link
Contributor Author

emerick commented Apr 5, 2022

CI passed; SonarCloud analysis failed with expected error for android pages.

@emerick emerick merged commit 41bf5b0 into master Apr 5, 2022
@emerick emerick deleted the rewards-reset-onboarding branch April 5, 2022 21:02
@emerick emerick added this to the 1.39.x - Nightly milestone Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave://settings/rewards incorrectly says Brave Rewards are disabled
3 participants