-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make successful reset of Rewards data also reset onboarding state #12877
Conversation
7fac2dc
to
3b42ace
Compare
A Storybook has been deployed to preview UI for the latest push |
onboardingCompletedStore.clear() | ||
chrome.send('brave_rewards.getOnboardingStatus') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we make this change to components/brave_rewards/resources/android_page/reducers/rewards_reducer.ts
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have it in there initially, but there's no onboarding overlay on the Android settings page. Maybe I should add it to the reducer anyway for consistency though? WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd probably still add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agreed. I added that in and a couple of missing onboarding-related case
statements to bring the android page in line with the desktop page.
3b42ace
to
88377f4
Compare
88377f4
to
4d81de9
Compare
A Storybook has been deployed to preview UI for the latest push |
CI passed; SonarCloud analysis failed with expected error for android pages. |
Resolves brave/brave-browser#22003
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: