-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poll device list during long initial commits procedure #17077
Conversation
e33218e
to
46470c3
Compare
46470c3
to
3183d14
Compare
3183d14
to
d2e41b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
d8d6a58
to
2fdee2b
Compare
Reproduced the original issue using the STR/Cases outlined via brave/brave-browser#27931 (comment) on
Using a
Verification PASSED on
Using the same STR/Cases I ran through the above with the guidance of #17077 (comment), ensured that
I also ensured that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
This fixes crash at BraveSyncerDevicePoll fixes brave/brave-browser#35554
This fixes crash at BraveSyncerDevicePoll fixes brave/brave-browser#35554
#21746) This fixes crash at BraveSyncerDevicePoll fixes brave/brave-browser#35554
Issue happens because at Syncer::BuildAndPostCommits loop is executed till all the records will be sent. It can take significant amount of time, ~10 minutes for 20k records, and during this time device can't receive updates.
This PR adds forced get updates only of device type to get the updates if large commit initial happens.
Resolves brave/brave-browser#27931
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
import_20k.zip
Test plan
import_20k/import1
folder from attached zip. Similar for device2 =>import_20k/import1
;device1;device2;device3
on each device list in approx ~15..35 seconds.