Use buildflag instead of defines gn var #17443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
reviewed
Mar 2, 2023
components/brave_vpn/browser/connection/win/brave_vpn_helper/BUILD.gn
Outdated
Show resolved
Hide resolved
simonhong
force-pushed
the
brave_vpn_buildflag
branch
from
616876e
to
4e93e4f
Compare
goodov
approved these changes
Mar 2, 2023
brave-builds
added a commit
that referenced
this pull request
Mar 3, 2023
7 tasks
kjozwiak
pushed a commit
that referenced
this pull request
Mar 3, 2023
Uplift of #17443 (squashed) to beta
bridiver
reviewed
Nov 28, 2023
| import("//build/buildflag_header.gni") | ||
| import("buildflags.gni") | ||
|
|
||
| buildflag_header("buildflags") { | ||
| header = "buildflags.h" | ||
| flags = [ "ENABLE_BRAVE_VPN=$enable_brave_vpn" ] | ||
|
|
||
| if (is_win) { |
There was a problem hiding this comment.
This absolutely does not belong here. We shouldn't be exposing channel information through a brave_vpn buildflag
There was a problem hiding this comment.
there's really no reason for the vpn helper to be in components in the first place since it's win specific so it can just use install_static::GetChromeChannel
plus there are already layering violations in here with install_static
There was a problem hiding this comment.
Filed brave/brave-browser#35260 and working on it from #20754 branch.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28848
No functional changes.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: