-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction balance and network #18477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavneet-Sing
added
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
CI/skip-windows-x86
CI/skip-windows-x64
Do not run CI builds for Windows x64
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
labels
May 15, 2023
Pavneet-Sing
commented
May 15, 2023
Comment on lines
+310
to
+312
fetchTxBalanceAndUpdateUi( | ||
view, selectedNetwork, accounts, filterByTokens); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This has been refactored, though LMK if further refactoring of the container method is desired.
Pavneet-Sing
force-pushed
the
fix-transaction-balance-and-network
branch
from
May 15, 2023 09:52
91e80fa
to
34283d2
Compare
android/java/org/chromium/chrome/browser/crypto_wallet/fragments/dapps/AddTokenFragment.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/crypto_wallet/fragments/dapps/SignMessageFragment.java
Outdated
Show resolved
Hide resolved
SergeyZhukovsky
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-ios
Do not run CI builds for iOS
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
feature/web3/wallet
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24384
Resolves brave/brave-browser#30277
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
tx-network.webm