-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #32799: Use correct components for ad-blocking #20137
Conversation
633fec1
to
327f4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me other than one request
327f4f6
to
d6b9caa
Compare
40fc7e4
to
3701bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
components/brave_shields/browser/ad_block_component_installer.h
Outdated
Show resolved
Hide resolved
a15018c
to
ca0df4e
Compare
bc04e0d
to
2f359a1
Compare
2f359a1
to
25faf99
Compare
Verification PASSED on
Using the STR/information outlined via brave/brave-browser#32799 (comment), ensured that
Verification PASSED on
|
Resolves brave/brave-browser#32799
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: