-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ZCash account creation & balance resolution #20351
Conversation
7ca1513
to
b319609
Compare
A Storybook has been deployed to preview UI for the latest push |
...s/brave_wallet_ui/components/desktop/popup-modals/add-account-modal/create-account-modal.tsx
Outdated
Show resolved
Hide resolved
std::string MakeGetAddressUtxosURLParams( | ||
const std::vector<std::string>& addresses) { | ||
zcash::GetAddressUtxosRequest request; | ||
for (const auto& address : addresses) { | ||
request.add_addresses(address); | ||
} | ||
request.set_maxentries(1); | ||
request.set_startheight(0); | ||
return GetPrefixedProtobuf(request.SerializeAsString()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok from privacy perspective to send account's addresses in a batch request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally no, although if these are one time use addresses it's less concerning but if we can avoid it we should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it takes only 1 address
cf97b64
to
c37d36f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the 2 new strings
A Storybook has been deployed to preview UI for the latest push |
/build linux |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Wallet Front-end
[Resolved] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
A Storybook has been deployed to preview UI for the latest push |
You don't need to access ZCashRpc directly |
iOS ++ |
Resolves brave/brave-browser#32305
Adds some functionality related to ZCash:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: