Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow first tab to be selected at edge of screen in fullscreen #21989

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#35932

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing changed the title All first tab to be selected at edge of screen in fullscreen Allow first tab to be selected at edge of screen in fullscreen Feb 9, 2024
@zenparsing zenparsing force-pushed the ksmith-first-tab-hit branch 3 times, most recently from 026492a to 06b6b52 Compare February 11, 2024 20:08
@zenparsing zenparsing marked this pull request as ready for review February 11, 2024 22:29
@zenparsing zenparsing marked this pull request as draft February 12, 2024 02:33
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

browser/ui/views/tabs/brave_tab_style_views.inc.cc Outdated Show resolved Hide resolved
browser/ui/views/tabs/brave_tab_strip.cc Outdated Show resolved Hide resolved
@zenparsing zenparsing marked this pull request as ready for review February 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left most tab not selected when clicking left side of the browser
2 participants