Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 #23896

Merged
merged 4 commits into from
May 29, 2024

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented May 29, 2024

Resolves brave/brave-browser#38675

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium requested review from a team as code owners May 29, 2024 17:35
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label May 29, 2024
Copy link
Contributor

[puLL-Merge] - brave/brave-core@23896

Description

This pull request makes various changes across the Chromium codebase. The main motivation seems to be to add Brave-specific functionality and preferences.

Changes

Changes

  • app/extensions_strings.grdp, app/extensions_strings_override.grdp, app/generated_resources.grd:
    • Adds new message strings related to extensions deprecation, Google Lens, and profile reporting
  • chrome/browser/BUILD.gn, chrome/browser/about_flags.cc, chrome/browser/prefs/browser_prefs.cc, chrome/browser/ui/BUILD.gn, chrome/browser/ui/browser.cc, chrome/browser/ui/views/location_bar/location_bar_view.cc, chrome/browser/ui/views/permissions/permission_prompt_bubble_base_view.cc, chrome/browser/ui/webui/extensions/extensions_ui.cc, chrome/test/BUILD.gn:
    • Adds Brave-specific build flags, About flags entries, preference registrations, and UI customizations
  • chrome/browser/renderer_context_menu/render_view_context_menu.cc, chrome/browser/resources/extensions/item_list.html, chrome/browser/resources/extensions/item_list.ts:
    • Modifies extension context menu and item list UI
  • components/sync/protocol/proto_visitors.h, components/sync/service/BUILD.gn, components/sync/service/sync_service_impl.h:
    • Adds support for Brave Sync
  • content/browser/browser_main_runner_impl.cc, content/browser/renderer_host/navigation_controller_impl.cc, content/browser/renderer_host/navigation_request.cc:
    • Injects Brave-specific functionality into content layer
  • ios/chrome/browser/shared/model/prefs/browser_prefs.mm:
    • Registers Brave-specific preferences on iOS
  • services/network/public/cpp/BUILD.gn:
    • Adds a Brave-specific build flag
  • third_party/blink/renderer/platform/runtime_enabled_features.json5:
    • Enables a Brave-specific runtime feature flag
  • package.json:
    • Bumps Chromium version to 126.0.6478.26

Overall, this PR adds a significant amount of Brave customizations across different layers of the Chromium codebase.

Copy link
Contributor

The following commits were not verified:
5dfe1d6 (unsigned)
9b55d76 (unsigned)
56884a9 (unsigned)
4fc0390 (unsigned)

@emerick emerick changed the title V126.0.6478.26 Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 May 29, 2024
@emerick emerick added the CI/run-network-audit Run network-audit label May 29, 2024
@emerick emerick requested a review from a team May 29, 2024 17:56
@emerick emerick added this to the 1.68.x - Nightly milestone May 29, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjozwiak kjozwiak merged commit 1c4a764 into master May 29, 2024
19 checks passed
@kjozwiak kjozwiak deleted the v126.0.6478.26 branch May 29, 2024 21:00
emerick pushed a commit that referenced this pull request May 29, 2024
* Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Updated strings for Chromium 126.0.6478.26.
emerick pushed a commit that referenced this pull request May 29, 2024
* Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Updated strings for Chromium 126.0.6478.26.
kjozwiak pushed a commit that referenced this pull request May 30, 2024
* [CodeHealth] Use span for args on `redirect_cc` (#23698)

This change corrects the build errors when building `redirect_cc` with
`-Wunsafe-buffers-usage`, by introducing a span argument to handle
access to the array of strings in `argv`. The resulting code is more
readable, and also relies on the hardening features available to span.

* Bytecode tests for static methods (#23699)

* Static/regular method is now arg of methodExists
* Removed Brave**** classes from methodExists/classExists tests

* Merge pull request #23233 from brave/cr126

Upgrade from Chromium 125 to Chromium 126

* Fix test_data dependency. (#23841)

* Merge pull request #23862 from brave/search_promotion_layout

Fixed search promotion's layout regression

* Merge pull request #23869 from brave/cr126-followup-fix-share-this-page-icon

Use Brave branded icon for Share this page

* Merge pull request #23868 from brave/cr126-followup-fix-settings-icons

Fix use of upstream icons in brave://settings

* Merge pull request #23871 from brave/cr126-followup-disable-pwa-universal-install

Disable PWA universal install feature flag

* Merge pull request #23874 from brave/cr126-followup-disable-security-privacy-feature-flags

Disable features flagged by privacy/security team

* Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 (#23896)

* Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Updated strings for Chromium 126.0.6478.26.

* Merge pull request #23897 from brave/android_search_widget_crash

Fixes a crash on search widget on Android

* Merge pull request #23894 from brave/cr126-followup-disable-sync-promo

Disable showing sync promo

* Merge pull request #23902 from brave/cr126-followup-fix-dangerous-downloads-ui

Disable safe_browsing::kImprovedDownloadPageWarnings feature flag

* Merge pull request #23909 from brave/help_bubble_view_button_regressions

Fixed HelpBubbleView's secondary button text is not visible

* Fixed color of switch at Shields and content filters (#23910)

Fixed color of switch at Shields and content filters

---------

Co-authored-by: cdesouza-chromium <cdesouza@brave.com>
Co-authored-by: AlexeyBarabash <AlexeyBarabash@users.noreply.github.com>
Co-authored-by: goodov <5928869+goodov@users.noreply.github.com>
Co-authored-by: Simon Hong <shong@brave.com>
Co-authored-by: Serg <serg.zhukovsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit puLL-Merge
Projects
None yet
3 participants