Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 125 to Chromium 126 (1.67.x) #23832

Merged
merged 15 commits into from
May 30, 2024
Merged

Upgrade from Chromium 125 to Chromium 126 (1.67.x) #23832

merged 15 commits into from
May 30, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 24, 2024 •
edited
Loading

Resolves brave/brave-browser#37788
Uplift from #23233

Resolves brave/brave-browser#38370
Uplift from #23698

Resolves brave/brave-browser#38401
Uplift from #23699

Resolves brave/brave-browser#38596
Uplift from #23841

Resolves brave/brave-browser#38579
Uplift from #23862

Resolves brave/brave-browser#38601
Uplift from #23869

Resolves brave/brave-browser#38593
Resolves brave/brave-browser#38595
Uplift from #23868

Resolves brave/brave-browser#38599
Uplift from #23871

Resolves brave/brave-browser#38644
Uplift from #23874

Resolves brave/brave-browser#38675
Uplift from #23896

Resolves brave/brave-browser#38680
Uplift from #23897

Resolves brave/brave-browser#38663
Uplift from #23894

Resolves brave/brave-browser#38657
Uplift from #23902

Resolves brave/brave-browser#29964
Uplift from #23909

Resolves brave/brave-browser#38687
Uplift from #23910

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added this to the 1.67.x - Beta milestone May 24, 2024
@emerick emerick self-assigned this May 24, 2024
@emerick emerick requested a review from a team as a code owner May 24, 2024 19:18
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels May 24, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

cdesouza-chromium and others added 8 commits May 29, 2024 18:22
@cdesouza-chromium @emerick
[CodeHealth] Use span for args on redirect_cc (#23698)
57d1862 
This change corrects the build errors when building `redirect_cc` with
`-Wunsafe-buffers-usage`, by introducing a span argument to handle
access to the array of strings in `argv`. The resulting code is more
readable, and also relies on the hardening features available to span.
@AlexeyBarabash @emerick
Bytecode tests for static methods (#23699)
8215ac0 
* Static/regular method is now arg of methodExists
* Removed Brave**** classes from methodExists/classExists tests
@emerick
Merge pull request #23233 from brave/cr126
336ef9a 
Upgrade from Chromium 125 to Chromium 126
@goodov @emerick
Fix test_data dependency. (#23841)
764a697
@simonhong @emerick
Merge pull request #23862 from brave/search_promotion_layout
ac53b0d 
Fixed search promotion's layout regression
@emerick
Merge pull request #23869 from brave/cr126-followup-fix-share-this-pa…
0ac3948 
…ge-icon

Use Brave branded icon for Share this page
@emerick
Merge pull request #23868 from brave/cr126-followup-fix-settings-icons
cb65b95 
Fix use of upstream icons in brave://settings
@emerick
Merge pull request #23871 from brave/cr126-followup-disable-pwa-unive…
fd33fb0 
…rsal-install

Disable PWA universal install feature flag
emerick and others added 3 commits May 29, 2024 18:22
@emerick
Merge pull request #23874 from brave/cr126-followup-disable-security-…
9332374 
…privacy-feature-flags

Disable features flagged by privacy/security team
@cdesouza-chromium @emerick
Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 (#23896)
31878ae 
* Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26.

* Updated strings for Chromium 126.0.6478.26.
@SergeyZhukovsky @emerick
Merge pull request #23897 from brave/android_search_widget_crash
9189557 
Fixes a crash on search widget on Android
SergeyZhukovsky
SergeyZhukovsky reviewed May 29, 2024
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

emerick and others added 2 commits May 30, 2024 06:58
@emerick
Merge pull request #23902 from brave/cr126-followup-fix-dangerous-dow…
f460a9f 
…nloads-ui

Disable safe_browsing::kImprovedDownloadPageWarnings feature flag
@simonhong @emerick
Merge pull request #23909 from brave/help_bubble_view_button_regressions
bb9fb23 
Fixed HelpBubbleView's secondary button text is not visible
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@AlexeyBarabash @emerick
Fixed color of switch at Shields and content filters (#23910)
1075772 
Fixed color of switch at Shields and content filters
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.67.x approved 👍

@kjozwiak kjozwiak merged commit e4223ea into 1.67.x May 30, 2024
14 checks passed
@kjozwiak kjozwiak deleted the cr126-1.67.x branch May 30, 2024 22:19
@kjozwiak kjozwiak mentioned this pull request May 30, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky left review comments

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.
8 participants
@emerick @brave-builds @kjozwiak @SergeyZhukovsky @cdesouza-chromium @AlexeyBarabash @goodov @simonhong