Fixed search promotion's layout regression #23862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/brave-browser#38579 Use flex layout to OmniboxResultView when promotion view is the only visible child to have sufficient height.
sangwoo108
approved these changes
May 28, 2024
Comment on lines
+51
to
+52
| // Reset upstream's layout manager. | ||
| SetLayoutManager(std::make_unique<views::FillLayout>()); |
There was a problem hiding this comment.
Out of curiosity, is this needed because FlexLayout might have been set?
There was a problem hiding this comment.
If not set, original result view layout is broken. OmniboxResultView uses FillLayout.
24 tasks
emerick
pushed a commit
that referenced
this pull request
May 29, 2024
Fixed search promotion's layout regression
kjozwiak
pushed a commit
that referenced
this pull request
May 30, 2024
* [CodeHealth] Use span for args on `redirect_cc` (#23698) This change corrects the build errors when building `redirect_cc` with `-Wunsafe-buffers-usage`, by introducing a span argument to handle access to the array of strings in `argv`. The resulting code is more readable, and also relies on the hardening features available to span. * Bytecode tests for static methods (#23699) * Static/regular method is now arg of methodExists * Removed Brave**** classes from methodExists/classExists tests * Merge pull request #23233 from brave/cr126 Upgrade from Chromium 125 to Chromium 126 * Fix test_data dependency. (#23841) * Merge pull request #23862 from brave/search_promotion_layout Fixed search promotion's layout regression * Merge pull request #23869 from brave/cr126-followup-fix-share-this-page-icon Use Brave branded icon for Share this page * Merge pull request #23868 from brave/cr126-followup-fix-settings-icons Fix use of upstream icons in brave://settings * Merge pull request #23871 from brave/cr126-followup-disable-pwa-universal-install Disable PWA universal install feature flag * Merge pull request #23874 from brave/cr126-followup-disable-security-privacy-feature-flags Disable features flagged by privacy/security team * Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 (#23896) * Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Updated strings for Chromium 126.0.6478.26. * Merge pull request #23897 from brave/android_search_widget_crash Fixes a crash on search widget on Android * Merge pull request #23894 from brave/cr126-followup-disable-sync-promo Disable showing sync promo * Merge pull request #23902 from brave/cr126-followup-fix-dangerous-downloads-ui Disable safe_browsing::kImprovedDownloadPageWarnings feature flag * Merge pull request #23909 from brave/help_bubble_view_button_regressions Fixed HelpBubbleView's secondary button text is not visible * Fixed color of switch at Shields and content filters (#23910) Fixed color of switch at Shields and content filters --------- Co-authored-by: cdesouza-chromium <cdesouza@brave.com> Co-authored-by: AlexeyBarabash <AlexeyBarabash@users.noreply.github.com> Co-authored-by: goodov <5928869+goodov@users.noreply.github.com> Co-authored-by: Simon Hong <shong@brave.com> Co-authored-by: Serg <serg.zhukovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#38579
Use flex layout to OmniboxResultView when promotion view is the only visible child to have sufficient height.
simplescreenrecorder-2024-05-28_12.12.06.webm
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
See the linked issue