-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable ReportingObserver and make noop #24726
Merged
ShivanKaul
merged 5 commits into
master
from
bugfix/make-reporting-observer-noop-instead-of-disable
Jul 19, 2024
Merged
Re-enable ReportingObserver and make noop #24726
ShivanKaul
merged 5 commits into
master
from
bugfix/make-reporting-observer-noop-instead-of-disable
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivanKaul
force-pushed
the
bugfix/make-reporting-observer-noop-instead-of-disable
branch
from
July 18, 2024 17:28
529f4b2
to
5cd781a
Compare
emerick
reviewed
Jul 18, 2024
chromium_src/third_party/blink/renderer/core/frame/reporting_observer.cc
Outdated
Show resolved
Hide resolved
chromium_src/third_party/blink/renderer/core/frame/reporting_observer.cc
Outdated
Show resolved
Hide resolved
emerick
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src++
bridiver
approved these changes
Jul 18, 2024
ShivanKaul
deleted the
bugfix/make-reporting-observer-noop-instead-of-disable
branch
July 19, 2024 16:19
brave-builds
added a commit
that referenced
this pull request
Jul 22, 2024
7 tasks
bsclifton
pushed a commit
that referenced
this pull request
Jul 22, 2024
7 tasks
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#39759 (comment), ensured that
|
kjozwiak
pushed a commit
that referenced
this pull request
Jul 22, 2024
Uplift of #24726 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
Jul 22, 2024
Uplift of #24726 (squashed) to release Co-authored-by: brave-builds <brave-builds+devops@brave.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#39759
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#39759