Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass base::TimeDelta by value #25813

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cdesouza-chromium
Copy link
Collaborator

For trivially copyable types like base::TimeDelta, we should avoid passing them as reference, as the cost is exactly the same as passing by value.

This change also turns many of the non-scoped constants into constexpr.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet++

For trivially copyable types like `base::TimeDelta`, we should avoid
passing them as reference, as the cost is exactly the same as passing by
value.

This change also turns many of the non-scoped constants into
`constexpr`.
@cdesouza-chromium cdesouza-chromium merged commit d67b301 into master Oct 4, 2024
17 checks passed
@cdesouza-chromium cdesouza-chromium deleted the pass-time-delta-by-value branch October 4, 2024 19:25
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 4, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants