Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "untargeted" category for Brave Ads / Ads History to "general" #5012

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 21, 2020

Resolves brave/brave-browser#6553

Submitter Checklist:

Test Plan:

Confirm untargeted ads appear as general in Ads History

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@@ -133,7 +133,7 @@ export default class TableAdsHistory extends React.PureComponent<Props, {}> {
return (
<StyledCategoryContentDiv>
<StyledCategoryName>
{content.category}
{content.category === 'untargeted' ? 'general' : content.category}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Categories in Ads History are not localized as they are downloaded with the catalog at this time, which is the reason general has not been localized for consistency

@tmancey
Copy link
Collaborator Author

tmancey commented Mar 22, 2020

Failed for unrelated Test-Security, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "untargeted" category label to "general" in Ads History panel
2 participants