Add eligible segment filter for bandits #7533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#13395
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
Run build with features cli args, e.g.
--enable-logging=stderr --vmodule="*/bat-native-ads/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --brave-ads-staging --rewards=staging=true --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
Case 1: Default models enabled (Text Classification and Purchase Intent)
Text classification feature is enabled
andPurchase intent feature is enabled
Extracting purchase intent signal from visited URL
andExtracted purchase intent signal from visited URL
Exploring epsilon greedy bandit segments: ...
orExploiting epsilon greedy bandit segments: ...
Case 2: Variant models enabled (Epsilon Greedy Bandit and Purchase Intent:
--disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
)Epsilon greedy bandit feature is enabled
andPurchase intent feature is enabled
andText classification feature is disabled
Extracting purchase intent signal from visited URL
andExtracted purchase intent signal from visited URL
Exploring epsilon greedy bandit segments: ...
orExploiting epsilon greedy bandit segments: ...
Case 3: Restart after one round of training and make sure state wasn't deleted in user Preferences JSON key
epsilon_greedy_bandit_arms