Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add option to drag drag/rearrange favorites via NTP #3713

Closed
anthonypkeane opened this issue May 24, 2021 · 5 comments · Fixed by #4401
Closed

Add option to drag drag/rearrange favorites via NTP #3713

anthonypkeane opened this issue May 24, 2021 · 5 comments · Fixed by #4401

Comments

@anthonypkeane
Copy link

Description:

Lets figure out a way to drag drag/rearrange favorites

Review

why can’t we drag/rearrange favorites on the home page in the order we like?…

@iccub
Copy link
Contributor

iccub commented May 25, 2021

you can do it from the overlay screen cc @kylehickinson

@kylehickinson
Copy link
Collaborator

Yeah the reason why we dont allow rearranging on the main NTP is because you aren't able to see all your favourites like you can once you focus the URL bar. We could perhaps enable rearranging on the NTP but you'd only be able to drag & drop between your top 4

@iccub
Copy link
Contributor

iccub commented Oct 17, 2021

Requirements:
Allow user to rearrange the visible favorites on NTP. Favorites outside of visible ones do not need to be handled.

@srirambv
Copy link
Contributor

srirambv commented Nov 4, 2021

Blocked on #4463

@srirambv srirambv changed the title Add option to drag drag/rearrange favorites Add option to drag drag/rearrange favorites via NTP Nov 4, 2021
@iccub iccub modified the milestones: 1.32.5, 1.33 Dec 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2021

Labelling this one as Verified/Passed as verifications were completed via #4463 (comment). The only remaining issue is #4651 on iOS 14 which will be QA'd in that particular GH issue. As per #4651 (comment), we're reverting the change for iOS 14 so you can't move the NTP tiles around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.