Scan QR Code shortcut missing when tapping Brave icon

[kjozwiak]

Description:

Looks like we're missing the Scan QR Code shortcut under the context menu when tapping and holding the Brave icon. Reported by @srirambv.

Steps to Reproduce

1. install 1.27.x via TF
2. long tap the Brave icon and notice that the Scan QR Code is missing

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible when running through the above STR

Brave Version:

• 1.27 (21.6.15.14) - *Reproduced

Device details:

• iPhone 11 running iOS 14.6 - Reproduced
• iPhone 12 running iOS 14.6 - Reproduced

Website problems only:

• did you check with Brave Shields down? N/A
• did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @anthonypkeane @Brandon-T @iccub @kylehickinson

[kjozwiak]

Can probably get this in the next release if possible. Wouldn't consider this a blocker for 1.27.

[iccub]

Yes, better to move it to 1.28

[Brandon-T]

This is not in the spec for "Search Overlay".

[kjozwiak]

@anthonypkeane is this something we want as well? As mentioned by @Brandon-T, this wasn't in the spec. I think it would be a good addition.

[anthonypkeane]

1.28 or later works

…

On Jun 16, 2021, at 18:54, Kamil Jozwiak ***@***.***> wrote:  @anthonypkeane is this something we want as well? As mentioned by @Brandon-T, this wasn't in the spec. I think it would be a good addition. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[srirambv]

Verification passed on the following devices running 1.31(21.8.25.18)

• Verified Scan QR Code shortcut is shown when long pressed on home screen app icon
• Verified Camera option opens up when Scan QR Code is selected
• Verified page loads correctly with the QR scan code
• Verified Scan QR Code works on both normal and PB only mode

iPhone XR (iOS 13.5)	iPhone 7+ (iOS 14.5.1)	iPad Pro (iOS 14.6)