Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Allow playlist items to be shared #4191

Closed
iccub opened this issue Sep 17, 2021 · 1 comment · Fixed by #4192
Closed

Allow playlist items to be shared #4191

iccub opened this issue Sep 17, 2021 · 1 comment · Fixed by #4192
Assignees
@Brandon-T
Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.32.1

Comments

@iccub
Copy link
Contributor

iccub commented Sep 17, 2021 •
edited
Loading

Add UI so the played item can be shared.

It can be added to:

  • long press gesture
  • swipe action

Upon one of those actions, a action sheet will show up with 2 actions:

  • open in Brave: this closes playlist and opens the media url in new tab
  • share: this opens standard share sheet with media url
@iccub iccub added this to the 1.32 milestone Sep 17, 2021
@Brandon-T Brandon-T mentioned this issue Sep 17, 2021
Merged
7 tasks
@iccub iccub assigned iccub and Brandon-T and unassigned iccub Sep 27, 2021
iccub pushed a commit that referenced this issue Oct 5, 2021
@Brandon-T
Fix #4191: Allow sharing Brave Playlist, fix Time Formatting for >= 1…
e6a4c82 
…-Hour (#4192)
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8 running 1.31.2(21.10.20.18)

  • Verified swipe on playlist item shows the share button\
  • Verified clicking on share button brings up action sheet with Open in New Tab / Open in Private Tab / Share options
  • Verified selecting new tab opens the link in a new tab
  • Verified selecting new private tab opens the link in a private tab
  • Verified selecting share brings up the regular share sheet
  • Verified able to successfully share the item to another app via the share sheet
image image image

Verification passed on iPhone XR with iOS 15.0.1 running 1.31.2(21.10.20.18)

  • Verified swipe on playlist item shows the share button\
  • Verified clicking on share button brings up action sheet with Open in New Tab / Open in Private Tab / Share options
  • Verified selecting new tab opens the link in a new tab
  • Verified selecting new private tab opens the link in a private tab
  • Verified selecting share brings up the regular share sheet
  • Verified able to successfully share the item to another app via the share sheet
image image image

Verification passed on iPad Pro with iOS 15.1 Beta 3 running 1.31.2(21.10.20.18)

  • Verified swipe on playlist item shows the share button\
  • Verified clicking on share button brings up action sheet with Open in New Tab / Open in Private Tab / Share options
  • Verified selecting new tab opens the link in a new tab
  • Verified selecting new private tab opens the link in a private tab
  • Verified selecting share brings up the regular share sheet
  • Verified able to successfully share the item to another app via the share sheet
image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.32.1
Development

Successfully merging a pull request may close this issue.

Fix #4191: - Allow sharing Brave Playlist + Fix Time Formatting for >= 1-Hour brave/brave-ios
3 participants
@Brandon-T @iccub @srirambv