Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Brave’s action ‘Create PDF’ not working since 1.31 update #4193

Closed
iccub opened this issue Sep 18, 2021 · 2 comments · Fixed by #4216
Closed

Brave’s action ‘Create PDF’ not working since 1.31 update #4193

iccub opened this issue Sep 18, 2021 · 2 comments · Fixed by #4216
Assignees
@iccub
Labels
bug Epic: UI/UX iOS 14 iOS 15 QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.31.1

Comments

@iccub
Copy link
Contributor

iccub commented Sep 18, 2021

Investigate:
https://community.brave.com/t/brave-s-action-create-pdf-not-working-since-1-31-update/284008
@kylehickinson
Copy link
Collaborator

Looks like it still works properly if you use the Create PDF action inside the share sheet instead of from the menu, so perhaps something broke in the menu part somehow.

@iccub iccub added this to the 1.31.1 milestone Sep 22, 2021
@iccub iccub self-assigned this Sep 23, 2021
iccub added a commit that referenced this issue Sep 23, 2021
@iccub
Fix #4193: Create PDF activity broke with XCode 13 compiler.
2416a59
@iccub iccub mentioned this issue Sep 23, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Sep 23, 2021
@iccub
Fix #4193: Create PDF action from 3dot menu not working.
3e63a71
iccub added a commit that referenced this issue Sep 23, 2021
@iccub
Fix #4193: Create PDF action from 3dot menu not working.
38fc175
iccub added a commit that referenced this issue Sep 23, 2021
@iccub
Fix #4193: Create PDF action from 3dot menu not working. (#4216)
db0fcb3
iccub added a commit that referenced this issue Sep 24, 2021
@iccub
Fix #4193: Create PDF action from 3dot menu not working. (#4216)
115b81f
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.31.1(21.9.27.15)

iPhone 7+ (iOS 14.8) iPad Pro (iOS 15)

@srirambv srirambv mentioned this issue Oct 1, 2021
Closed
@kylehickinson kylehickinson mentioned this issue Feb 2, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug Epic: UI/UX iOS 14 iOS 15 QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.1
Development

Successfully merging a pull request may close this issue.

Fix #4193: Create PDF activity broke with XCode 13 compiler. brave/brave-ios
3 participants
@kylehickinson @iccub @srirambv