Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3735: Add search button doesn't resize correctly when moving between text fields #3926

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jul 14, 2021

Changing view responder method to satisfy new refresh control condition and fixing trailing button bug in iPad

Summary of Changes

This pull request fixes #3735

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Visit GitHub and open search to bring up keyboard
Use Up/Down arrow keys to move between text fields
Disabled add search button is not resized

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.30 milestone Jul 14, 2021
@soner-yuksel soner-yuksel self-assigned this Jul 14, 2021
@iccub iccub modified the milestones: 1.30, 1.29 Jul 15, 2021
@soner-yuksel soner-yuksel merged commit 5bff8f3 into development Jul 15, 2021
@soner-yuksel soner-yuksel deleted the fix/engine-keyboard-button branch July 15, 2021 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search button doesn't resize correctly when moving between text fields
2 participants