Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7796, Fix #6966: Use webViewDidClose to handle window.close #7797

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix #7796, Fix #6966: Use webViewDidClose to handle window.close #7797

merged 1 commit into from
Jul 28, 2023

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #7796
This pull request fixes #6966

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner July 28, 2023 14:17
@kylehickinson kylehickinson added this to the 1.57 milestone Jul 28, 2023
@JustinHook
Copy link

@kylehickinson thanks for the quick fix. Do you have an estimate for when this will be released?

@kylehickinson
Copy link
Collaborator Author

@JustinHook it'll be scheduled for 1.57 which is likely going to be around mid-August

@kylehickinson kylehickinson enabled auto-merge (squash) July 28, 2023 14:46
@kylehickinson kylehickinson merged commit e720c18 into development Jul 28, 2023
7 checks passed
@kylehickinson kylehickinson deleted the handle-window-close branch July 28, 2023 15:21
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7796, Fix brave/brave-ios#6966: Use `webViewDidCl…
ddf81e8 
…ose` to handle `window.close` (brave/brave-ios#7797)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@soner-yuksel soner-yuksel soner-yuksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.

Javascript window.close() not closing window Google Oauth window does not autoclose after success
4 participants
@kylehickinson @JustinHook @soner-yuksel @iccub