Setuptools #123
Merged
Setuptools #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2013 01:04
…r use PackageLoader instead of FileSystemLoader (this should then also work for brian2 installed as a zip file)
…ild documentation)
|
Great! I'll test it on Windows alter this afternoon and merge if all is fine. |
|
Also, good call on the |
|
OK works fine on Windows! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, the basic switch is done, if it works for you (I only tested on Linux), I think it is ready to merge.
Not much did change, there are some differences/new features, though:
ez_setupbootstrap file which automatically downloads setuptools if it is not installed already. This is irrelevant in most cases (where users use pip or easy_install to download from pypi) but is a nice extra if you download the source tarball or clone the repository from git.python setup.py build_sphinx(this needs sphinx, of course). I think it's nice to include the doc sources in the source tarball, a user downloading the package can then build the docs on their own machine. It doesn't take up much space since we do not have to include the reference section which is auto-generated.python setup.py nosetests-- this does not seem very useful at first (after all, you can also run nosetests directly), but it is a nice shortcut for testing under Python 3: just usepython3 setup.py nosetestsand it will run the code through2to3and then run the test suite on the Python3 code.As a general "note to ourselves": We should try not to rely on the
__file__attribute of modules but rather use thepkg_resourcemechanism (I changed this for the templates). In principle Python packages can be installed as single zip files and then the assumption of modules being files in the file system fails.