-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around the regression introduced in matplotlib 1.3.1 #274
Conversation
…Quantity.ravel` return a dimensionless array. Emit a warning explaining the issue. Closes #245
How about making |
Good idea, I'd probably raise a warning nevertheless -- in principle a user could be calling |
Oh yes, I'm happy with the warning to stay. Also, the Travis build seems to be failing. I'll review this one later today too. |
um right, I didn't update the tests to accept a unit-less result from |
I made the change conditional on matplotlib 1.3.1 and corrected the tests, test suite should pass now. |
Good timing, was just about to check this. :) |
Tests pass here, happy to merge if Travis build passes too. |
OK they pass - merging now. |
Work around the regression introduced in matplotlib 1.3.1
Does what I proposed in #245. Emits the following warning (will be only printed once) when the user tries to plot a quantity array (or calls
ar.ravel()
directly):