-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New name system #52
New name system #52
Conversation
…"basename" system and instead have default arguments like "neurongroup*". Does no longer automatically use source/target attributes to come up with a name. Closes #47.
Thanks for writing this Marcel. One slight issue before I merge. For |
While writing it I first thought of doing (2), but then it wouldn't be possible to have a more specific name automatically, i.e. not |
…the rest of the code.
Nice! Merging now. |
To get this out of the way, I implemented the changes to the naming system we discussed in #47 . Classes no longer have a
basename
attribute, instead they simply define e.g.neurongroup*
as the default value for thename
keyword argument. Internal objects that don't take a name argument might construct a name themselves, e.g. theTresholder
object calls theBrianObject
initializer withname=group.name+'_'+'thresholder*'
.