[MRG] Allow multiple objects with the same name at creation time #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For wildcard names, the same mechanism as before is used but explicitly given names are not checked for uniqueness at creation time. Instead, `Network.before_run` checks that all names within the network are unique. In addition, `CPPStandaloneDevice.build` checks that names are globally unique. Closes #216
|
Looks great - happy for it to be merged when the tests pass. |
mstimberg
added a commit
that referenced
this pull request
Aug 5, 2015
Allow multiple objects with the same name at creation time
|
I'm having problems with this, do you prefer discussion in brian-development rather than here? |
|
No I think it's fine to discuss it here if it is specifically about the change in this PR. If it is something that would be easier to sort out interactively, then you could also drop into our fancy (and more or less unused) chat: https://gitter.im/brian-team/brian2 (I'm off for lunch soon, though :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For wildcard names, the same mechanism as before is used but explicitly given names are not checked for uniqueness at creation time. Instead,
Network.before_runchecks that all names within the network are unique. In addition,CPPStandaloneDevice.buildchecks that names are globally unique. Closes #216This should be particularly useful in interactive consoles and ipython notebooks whenever explicit names for objects are used. Should also make @owenmackwood happy.