-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ast improvements #72
Ast improvements #72
Conversation
BitOr The reason for removing BitAnd and BitOr is that we want them to be equivalent to and and or in Python, but they have different precedence. Previously we were hacking this by replacing '&' with 'and' but this is confusing. Better to just simply use 'and' and 'or' I think.
…ession (still fails for function calls)
…units and _return_unit attribute in the function object.
…value evaluation. This is used in the unit checking and should allow to use constant scalar variables as an exponent.
I fixed a bug in the handling of "not" and worked around a Python 3 issue (arguments don't have an I'm only waiting for the current travis run to finish, then I'll merge. |
That's odd, github thinks the travis build failed but on the travis page, it completed without error. Either way, merging now. |
Improvements to the AST-based parsing, now a parsing-based approach to unit checking (instead of an eval-based) is used.
OK I think I've done all the work I wanted on this branch, written tests and documentation - it's ready to go!