Skip to content

Adds conditional for MYSQL_SECURE_AUTH #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabidavila wants to merge 1 commit into from
Closed

Adds conditional for MYSQL_SECURE_AUTH #898

gabidavila wants to merge 1 commit into from

Conversation

@gabidavila
Copy link

@gabidavila gabidavila commented Oct 31, 2017

Tries to fix #891 and adds a third conditional at #892 that was missing on line https://github.com/brianmario/mysql2/blob/master/ext/mysql2/client.c#L1428.

Since MYSQL_SECURE_AUTH was removed on 8.0.3

@yahonda
Copy link
Contributor

yahonda commented Oct 31, 2017

Hi, the condition you added had existed in the first commit at #892 and removed after the review 986aadc

@gabidavila
Copy link
Author

gabidavila commented Oct 31, 2017

Ok, I will close this then :)

@gabidavila gabidavila closed this Oct 31, 2017
@yahonda
Copy link
Contributor

yahonda commented Oct 31, 2017

Thank you.

@sodabrew sodabrew modified the milestones: 0.4.9, 0.4.10 Nov 11, 2017
This was referenced Mar 16, 2018
Merged
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.10

Development

Successfully merging this pull request may close these issues.

MySQL 8.0.3 Release Candidate removes MYSQL_SECURE_AUTH

3 participants

@gabidavila @yahonda @sodabrew