Skip to content

Conversation

@sodabrew
Copy link
Collaborator

Following up on #895

@sodabrew sodabrew added this to the 0.4.10 milestone Nov 12, 2017
@sodabrew sodabrew force-pushed the remove_mysqld_error_h branch from ebc9acd to 8a82466 Compare November 12, 2017 19:06
@sodabrew
Copy link
Collaborator Author

Verified that no constants from this file are in use:

awk '/define/ { print $2 }' /opt/local/include//mysql56/mysql/mysqld_error.h | xargs -I{} -- ag -ai {} ext/ lib/

Tested across several versions of MySQL.

@sodabrew sodabrew merged commit 763235e into brianmario:master Nov 12, 2017
@sodabrew sodabrew deleted the remove_mysqld_error_h branch November 12, 2017 20:33
@jaredbeck
Copy link
Contributor

jaredbeck commented Nov 13, 2017

Testing 763235e against MariaDB 10.2.10 installed by Homebrew, looks good 👍

git clone https://github.com/brianmario/mysql2.git
...
git show
commit 763235ec8311a28c8959628fee1fec4f07edfafa
...
gem build mysql2.gemspec 
...
gem install mysql2-0.4.9.gem 
Building native extensions. This could take a while...
Successfully installed mysql2-0.4.9
1 gem installed
mysql -v
Server version: 10.2.10-MariaDB Homebrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants