Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tests fail with BUILD_COLOUR_NAME_MAP=OFF #1940

Closed
billie80 opened this issue May 28, 2024 · 1 comment · Fixed by #1941
Closed

[Bug]: Tests fail with BUILD_COLOUR_NAME_MAP=OFF #1940

billie80 opened this issue May 28, 2024 · 1 comment · Fixed by #1941
Labels
bug Bug report or bug fix PR

Comments

@billie80
Copy link
Contributor

What happened?

With conky 1.21.0 the build option BUILD_COLOUR_NAME_MAP was introduced. When disabling the colour name map the color related test in test-colours.cc "parse_color correctly parses colours" fails.
Should this test be disabled in this case?

Version

1.21.1

Which OS/distro are you seeing the problem on?

Gentoo

Conky config

No response

Stack trace

No response

Relevant log output

No response

@billie80 billie80 added bug Bug report or bug fix PR triage Issue that hasn't been verified labels May 28, 2024
@brndnmtthws
Copy link
Owner

In this particular case, the name tests should just be disabled.

@brndnmtthws brndnmtthws removed the triage Issue that hasn't been verified label May 28, 2024
brndnmtthws added a commit that referenced this issue May 28, 2024
brndnmtthws added a commit that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants