Replace atoi and atol with strtol (most files). #1224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
atoi
and all three instances ofatol
withstrtol
to prevent undefined behavior.atoi
-using variables I could in patched and unpatchedconky
, and none of them appeared to show changed behavior. I haven't been able to test anything related toi8k.cc
,ibm.cc
,nvidia.cc
(don't have the hardware) oropenbsd.cc
(haven't managed to buildconky
). To be extra-safe, I've left those files out of the commit, but modified versions can be found in a separate branch called "untested-atoi." If I should push those as well, just let me know!Licenses