Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power draw added to conky #1241

Merged
merged 3 commits into from
Oct 8, 2022
Merged

power draw added to conky #1241

merged 3 commits into from
Oct 8, 2022

Conversation

brightkill
Copy link

Add a new option $battery_power_draw to see battery power draw in watts

@netlify
Copy link

netlify bot commented Oct 8, 2022

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 64befa6
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/63419cee9f4ff00008956f8f

@github-actions github-actions bot added documentation Issue or PR that suggests documentation improvements sources PR modifies project sources labels Oct 8, 2022
Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love C string functions, but otherwise looks good to me.

:shipit:

@brndnmtthws
Copy link
Owner

Looks like one small build issue on macOS, once that's addressed we should be good to go. You can just copy one of the stubs like this if you want to punt on implementing it:

conky/src/darwin.mm

Lines 1034 to 1037 in 30cad6a

int get_battery_perct(const char * /*bat*/) {
printf("get_battery_perct: STUB\n");
return 1;
}

@brightkill
Copy link
Author

done

@brndnmtthws brndnmtthws merged commit 3bf4f74 into brndnmtthws:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or PR that suggests documentation improvements sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants