WX-1625 Refactor ahead of quota retry #7432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgainerdewar
approved these changes
May 14, 2024
|
LGTM, excellent cleanup + clarity. |
THWiseman
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to figure out where to put quota retry, I made some changes to
StandardAsyncExecutionActorto help wrap my head around it.We probably ultimately want quota retried in
PipelinesApiAsyncBackendJobExecutionActor, but I think the refactor is worth checking in so the next person has an easier time.I also included a preparatory refactor that makes
isQuotaMessageavailable at the appropriate scope for use in the next PR, so it'll be smaller.