Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spark tools to write SAM files when a .sam suffix is specified. #4471

Merged
merged 1 commit into from May 11, 2018

Conversation

tomwhite
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #4471 into master will increase coverage by 0.017%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##              master    #4471       +/-   ##
==============================================
+ Coverage     80.062%   80.08%   +0.017%     
- Complexity     17417    17422        +5     
==============================================
  Files           1080     1080               
  Lines          63107    63131       +24     
  Branches       10196    10200        +4     
==============================================
+ Hits           50525    50555       +30     
+ Misses          8589     8583        -6     
  Partials        3993     3993
Impacted Files Coverage Δ Complexity Δ
...ender/engine/spark/datasources/ReadsSparkSink.java 77.698% <100%> (+4.654%) 29 <4> (+3) ⬆️
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 80% <0%> (+1.29%) 40% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lbergelson lbergelson merged commit 80e5ab9 into master May 11, 2018
@lbergelson lbergelson deleted the tw_spark_write_sam branch May 11, 2018 16:00
@lbergelson
Copy link
Member

@tomwhite Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants