Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-1761. Added more logging to IlluminaBasecallsToFastq #1735

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

gbggrant
Copy link
Contributor

Description

Added more logging to IlluminaBasecallsToFastq
Simplify implementation of awaitTileProcessingCompletion


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

Simplify implementation of awaitTileProcessingCompletion
Copy link
Collaborator

@jacarey jacarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jessicaway jessicaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems better to me!

@gbggrant gbggrant merged commit 84579ec into master Oct 20, 2021
@gbggrant gbggrant deleted the gg_UpdatesToIlluminaBasecallsTo branch October 20, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants