Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-1803. Fix issue where SOURCE fields from Illumina manifest may contain a semicolon #1738

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

gbggrant
Copy link
Contributor

Description

GL-1803. Fix issue in GtcToVcf where SOURCE fields from Illumina manifest may contain a semicolon which is not allowed in a VCF INFO field


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

…micolon

which is not allowed in a VCF INFO field
Update CombineGenotypingArrayVcfs to allow for diffs in SOURCE
@gbggrant gbggrant force-pushed the gg_GL-1803_IssueWithSourceFieldInArraysVcfs branch from 5ca0de7 to dcce39f Compare October 25, 2021 17:10
@gbggrant gbggrant merged commit 14f30fe into master Oct 25, 2021
@gbggrant gbggrant deleted the gg_GL-1803_IssueWithSourceFieldInArraysVcfs branch October 25, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants