Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for existence of .bpm file to CompareGtcFiles #1743

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

gbggrant
Copy link
Contributor

@gbggrant gbggrant commented Nov 4, 2021

Description

Updated CompareGtcFiles to do an up-front existence check for the Illumina bead pool manifest (.bpm) file.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@gbggrant gbggrant merged commit e35dab6 into master Nov 4, 2021
@gbggrant gbggrant deleted the gg_AddBpmExistenceValidationToCompareGtcFiles branch November 4, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants