Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the SamToFastq documentation #1920

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

kockan
Copy link
Contributor

@kockan kockan commented Nov 17, 2023

  • Updated the SamToFastq documentation to clarify that the tool works properly for both name-sorted and coordinate-sorted inputs
  • Fixed some whitespace issues

…roperly for both name-sorted and coordinate-sorted inputs. Fixed some whitespace issues.
@kockan
Copy link
Contributor Author

kockan commented Nov 17, 2023

For #1834

Copy link
Contributor

@gokalpcelik gokalpcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I forgot to mention this earlier but although mates come with the same order in both fastq files the behavior is different between name sorted vs coordinate sorted bam files. Name sorted bam files will produce the very same fastqs generated from the sequencer whereas coordinate sorted bams will result in a scrambled fastq files where mates match but reads are not sorted by name. This may result in slightly different outcomes when used with non-deterministic mappers such as bwa. Maybe we need to mention this briefly.

In summary you can still use paired fastqs generated by this tool for a reanalysis however resulting alignments may vary due to the nature of the mapper.

@kockan kockan merged commit 692918d into master Feb 13, 2024
6 checks passed
@kockan kockan deleted the can_sam2fastq_docs_update branch February 13, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants