POD-2826: Fix how floats and integers are handled when determining TDR Schema #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 79.66% 79.86% +0.19%
==========================================
Files 20 20
Lines 1938 1957 +19
==========================================
+ Hits 1544 1563 +19
Misses 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snovod
approved these changes
Jul 23, 2025
ncalvanese1
reviewed
Jul 23, 2025
| if all(isinstance(row_value, int) for row_value in non_nan_numbers): | ||
| return self.PYTHON_TDR_DATA_TYPE_MAPPING[int] | ||
| # If all values are float, return float type | ||
| elif all(isinstance(row_value, float) for row_value in non_nan_numbers): |
There was a problem hiding this comment.
Is this evaluation necessary if the default for non-all-integer is float either way?
There was a problem hiding this comment.
Ah good point, it's not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POD-2826