Skip to content

Conversation

dvoet
Copy link
Contributor

@dvoet dvoet commented Nov 13, 2015

https://broadinstitute.atlassian.net/browse/DSDEEPB-1975

  • Submitter: Rebase to develop. DO NOT SQUASH
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: Make sure documentation for code is complete
  • Submitter: Review code comments; remove done TODOs, create stories for remaining TODOs
  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Add description or comments on the PR explaining the hows/whys (if not obvious)
  • Tell that the PR exists if he wants to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • LR: Initial review by LR and others.
  • Comment / review / update cycle:
    • Rest of team may comments on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter updates documentation as needed
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH. Reassign to LR for further feedback
  • sign off
  • LR sign off
  • Assign to submitter to finalize
  • Submitter: Squash commits, rebase if necessary
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Check configuration files in Jenkins in case they need changes
  • Submitter: Verify swagger UI on dev server still works after deployment
  • Submitter: Inform other teams of any API changes via hipchat and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

…rent security and add new proxy config for ldap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config changes to allow proxy to access ldap

@helgridly
Copy link
Contributor

seems legit 👍

dvoet pushed a commit that referenced this pull request Nov 13, 2015
make create user under /register instead of /api
@dvoet dvoet merged commit a9014b8 into feature_graph_acl Nov 13, 2015
@dvoet dvoet deleted the register_end_points branch November 13, 2015 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants