-
Notifications
You must be signed in to change notification settings - Fork 29
final touches before launch #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* update urls, ts ignore fix (#8) * feat: add query param parsing (#9) * update urls, ts ignore fix * added query param parsing to instatiate chatfeed with query params * disable captcha solving if query params are passed in (#10) * update gemini model * update model tag (#12) * add region routing * more precise region & probability dist routing * no inline import * add dep --------- Co-authored-by: Kyle Jeong <77771518+Kylejeong2@users.noreply.github.com> Co-authored-by: Miguel <36487034+miguelg719@users.noreply.github.com>
This reverts commit 1ea7c9c.
* update urls, ts ignore fix (#8) * feat: add query param parsing (#9) * update urls, ts ignore fix * added query param parsing to instatiate chatfeed with query params * disable captcha solving if query params are passed in (#10) * update gemini model * update model tag (#12) * add region routing * more precise region & probability dist routing * no inline import * add dep --------- Co-authored-by: Kyle Jeong <77771518+Kylejeong2@users.noreply.github.com> Co-authored-by: Miguel <36487034+miguelg719@users.noreply.github.com>
This reverts commit 1ea7c9c.
…v-gemini-browser into sameel/flags-new
edge config for browser settings
The latest updates on your projects. Learn more about Vercel for GitHub.
|
return "PDT"; // Server-side fallback | ||
} | ||
|
||
const abbr = moment.tz(moment.tz.guess()).format("z"); | ||
return abbr; | ||
} catch { | ||
return "PDT"; // Fallback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return "PDT"; // Server-side fallback | |
} | |
const abbr = moment.tz(moment.tz.guess()).format("z"); | |
return abbr; | |
} catch { | |
return "PDT"; // Fallback | |
return "GMT"; // Server-side fallback - more globally neutral | |
} | |
const abbr = moment.tz(moment.tz.guess()).format("z"); | |
return abbr; | |
} catch { | |
return "GMT"; // Fallback - more globally neutral than PDT |
The timezone detection fallback is hardcoded to "PDT" (Pacific Daylight Time) for both server-side rendering and error cases, causing users worldwide to be incorrectly routed to US West Coast servers.
View Details
Analysis
Hardcoded PDT timezone fallback routes global users to US West Coast servers
What fails: getTimezoneAbbreviation()
in app/hooks/useAgentStream.ts
returns hardcoded "PDT" for server-side rendering and error cases, causing non-US users to be routed to us-west-2 region instead of geographically closer servers
How to reproduce:
// Server-side rendering scenario:
typeof window === "undefined" // returns "PDT"
// Error scenario:
moment.tz operations fail // returns "PDT"
// Both cases map PDT -> "us-west-2" via timezoneAbbreviationMap
Result: European and Asian users get routed to US West Coast servers (us-west-2) instead of eu-central-1 or ap-southeast-1, causing increased latency
Expected: Fallback should use a more globally neutral timezone like GMT which maps to eu-central-1, providing better geographic distribution for international users
Fix: Changed both fallback cases from "PDT" to "GMT" to route fallback users to eu-central-1 instead of us-west-2
what
Session routing, edge config, better prompts, remove search param parsing,