Skip to content

Conversation

giacomocaironi
Copy link
Member

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 6, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 0.79 ⭐ 0.80 ⭐ 0.01 👎
Method Length 96.93 🙂 98.32 🙂 1.39 👎
Working memory 7.65 🙂 7.66 🙂 0.01 👎
Quality 67.12% 🙂 67.15% 🙂 0.03% 👍
Other metrics Before After Change
Lines 515 521 6
Changed files Quality Before Quality After Quality Change
btclib/hashes.py 87.07% ⭐ 86.19% ⭐ -0.88% 👎
btclib/bip32/der_path.py 80.16% ⭐ 80.11% ⭐ -0.05% 👎
tests/tx/test_tx.py 60.26% 🙂 60.26% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/tx/test_tx.py test_tx 0 ⭐ 697 ⛔ 12 😞 46.17% 😞 Try splitting into smaller methods. Extract out complex expressions
tests/tx/test_tx.py test_dataclasses_json_dict 0 ⭐ 266 ⛔ 9 🙂 56.58% 🙂 Try splitting into smaller methods
tests/tx/test_tx.py test_coinbase_block_1 0 ⭐ 229 ⛔ 8 🙂 60.71% 🙂 Try splitting into smaller methods
tests/tx/test_tx.py test_double_witness 0 ⭐ 186 😞 5 ⭐ 71.16% 🙂 Try splitting into smaller methods
tests/tx/test_tx.py test_wiki_transaction 0 ⭐ 171 😞 5 ⭐ 72.48% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

show_error_codes = true
exclude = "build"
exclude = ["build"]
ignore_missing_imports = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to ignore missing imports globally? Isn't there a way to ignore specific cases locally instead?

@fametrano
Copy link
Member

superseeded by #78

@fametrano fametrano closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants