feat: add scheme configuration #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivchari
force-pushed
the
add-scheme-configuration
branch
2 times, most recently
from
3a750a6 to
4ddd70e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable scheme for the Bucketeer SDK, allowing the client to use either HTTP or HTTPS for API requests.
- Adds a scheme option to the Bucketeer options and default configuration.
- Updates tests to cover the new scheme option.
- Modifies API client URL construction to use the configurable scheme.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/bucketeer/sdk.go | Updated API client instantiation to pass the scheme configuration. |
| pkg/bucketeer/option_test.go | Added tests to assert correct scheme configuration. |
| pkg/bucketeer/option.go | Introduced scheme in options with a default value and the corresponding setter. |
| pkg/bucketeer/api/client.go | Added error definitions and validation for scheme, but missing assignment in client constructor. |
| pkg/bucketeer/api/api.go | Modified API URL constructions to use the configurable scheme. |
Comments suppressed due to low confidence (1)
pkg/bucketeer/api/client.go:65
- The ClientConfig's scheme field is not assigned to the client struct. Consider assigning the scheme (e.g., scheme: string(conf.Scheme)) to ensure that the URL is constructed using the configured scheme.
client := &client{ apiKey: conf.APIKey, host: conf.Host, }
24c820b to
8a0f3da
Compare
|
Hi, @cre8ivejp |
cre8ivejp
reviewed
Apr 7, 2025
pkg/bucketeer/api/api.go
Outdated
| } | ||
| if c.scheme == "http" { | ||
| client.Transport = &http.Transport{ | ||
| // This setting is for developping on local machine. |
There was a problem hiding this comment.
Suggested change
| // This setting is for developping on local machine. | |
| // This setting is for developing on local machines. |
sivchari
force-pushed
the
add-scheme-configuration
branch
from
8a0f3da to
e8d61f4
Compare
|
@cre8ivejp |
|
@sivchari, the e2e tests are failing. === NAME TestGetSegmentUsers
api_test.go:78:
Error Trace: /home/runner/work/go-server-sdk/go-server-sdk/test/e2e/api_test.go:227
/home/runner/work/go-server-sdk/go-server-sdk/test/e2e/api_test.go:78
Error: Received unexpected error:
scheme must be http or https
Test: TestGetSegmentUsers
--- FAIL: TestGetSegmentUsers (0.00s)You must also update here. |
sivchari
force-pushed
the
add-scheme-configuration
branch
2 times, most recently
from
13b193f to
54fcfde
Compare
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
force-pushed
the
add-scheme-configuration
branch
from
54fcfde to
b542494
Compare
|
@cre8ivejp |
|
ping |
cre8ivejp
approved these changes
Apr 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, go-server-sdk doesn't provide way to handle scheme and it's hard to debug on local since the all request send to as a HTTPS.
By making client's scheme configurable, we can use client not only hosting environment but also local one.