feat: add SDK version support to options #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnnkkk7
force-pushed
the
add/versionid-args
branch
2 times, most recently
from
ba77485 to
24855e0
Compare
nnnkkk7
commented
May 9, 2025
Comment on lines
-30
to
-34
| type registerEventsResponseError struct { | ||
| Retriable bool `json:"retriable,omitempty"` | ||
| Message string `json:"message,omitempty"` | ||
| } | ||
|
|
There was a problem hiding this comment.
This struct is unused now.
nnnkkk7
force-pushed
the
add/versionid-args
branch
from
24855e0 to
5e6956f
Compare
|
Just confirming. Are you going to add the source ID option in another PR, right? |
|
@cre8ivejp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to set the SDK version through options when creating a new SDK instance.
This change is necessary for building an OpenFeature provider to set SDK version .