Skip to content

v0.326.0 — UI review release A: real defects + dead-token deletion

Choose a tag to compare

@budgets-au budgets-au released this 13 Aug 08:00
· 45 commits to main since this release

Container

ghcr.io/budgets-au/budgets:0.326.0
ghcr.io/budgets-au/budgets:latest

First of four releases from a full UI-consistency review (three parallel audits over layout/navigation, design tokens/primitives, and page interaction patterns). This one is the "clear the decks" pass — real defects plus dead-token deletion, chosen because none of it has a visual consequence worth reviewing. Colour/control consolidation, chrome/table normalisation, and shared loading/empty states follow in 0.327–0.329.

Fixed

  • Transactions bulk-action bar was invisible while scrolling. sticky top-0 z-10 under a sticky top-0 z-20 h-14 Topbar — same offset, lower z-index, so it slid underneath the moment the page scrolled. Now top-14.
  • amountClass is now genuinely the single source of money colour.
    • Zero is muted, not green — 0 >= 0 put it in the positive branch, so a $0.00 row read as a gain.
    • dark: variants baked in. The helper had none while ~7 hand-rolled call sites added their own, so the two families diverged in dark mode only.
    • Nullish / non-finite input returns the muted tone, so callers can pass a possibly-absent average without a guard.
    • This let the forked local copy in category-report.tsx go. It was also emitting text-rose-600 where every other table used text-red-500 — so the Category report had been rendering negatives in a different hue since 0.320.
  • font-mono did nothing. --font-mono aliased --font-geist-mono, defined nowhere, so all 12 files using it for code / import hashes / FITIDs silently inherited the sans body font. Alias dropped; Tailwind's built-in monospace stack now applies.
  • data-size="lg" on a Card was a silent no-op — ui/card.tsx implements sm only. Dropped from the Forward balance widget (0.325).
  • --cashflow-chrome was a phantom token — consumed by two bounded-height table wrappers, defined nowhere, always falling back. Now defined in :root so the offset is tunable in one place.
  • Print leaked dark-mode money colours onto paper. The print block overrides the -500/-600 status tints with darker -700 shades but had no -400 rule, which amountClass now emits under .dark.

Changed

  • Mobile navigation drawer is dismissible and modal. Escape closes it, the page behind no longer scrolls under it, and it announces itself with role="dialog" / aria-modal / aria-label while open — conditionally, since at lg it's permanent page furniture where a dialog role would be a lie. Hamburger gained aria-expanded / aria-controls. A proper focus trap is a larger lift and is not included.

Removed

  • 13 dead design tokens — --chart-1…--chart-5 and all eight --sidebar-*, plus their 13 @theme aliases, in both light and dark blocks. Zero references anywhere in src/**: charts read hex from lib/colours.ts (Recharts can't consume var(), so the chart tokens could never have worked as written) and the sidebar styles itself with bg-background / bg-indigo-600 directly. .dark --sidebar-primary was the only chromatic value in the entire neutral token set — a leftover shadcn blue.

Audit notes

Three findings were investigated and rejected rather than actioned — worth recording so they don't get "fixed" later:

  • The sample-data / orphan-categories panels reportedly hung on "Checking…" after a failed fetch. They already branch on SWR error before the loading check, and returning null is deliberate: non-admins get a 401 and the panel should hide for them.
  • edit-investment-dialog reportedly deleted a vest without confirmation. That delete is the consequence of an explicit Save on a form the user already confirmed, not a direct destructive action — a second modal mid-save would be worse. (It did surface a genuine unrelated gap: three unchecked fetch calls in that sync path fail silently. Tracked separately.)
  • The print block's hard-coded hex reportedly duplicated tokens. It deliberately does not match them — print needs more contrast than the on-screen tokens provide, which is the entire reason those rules exist.

Verify

  • tsc clean, pnpm build clean.
  • 731/741 unit tests. The amountClass suite was rewritten against the new contract; the two failures it produced first were the old behaviour being correctly pinned.
  • pages-smoke 12/12 green.

Upgrade

Pull ghcr.io/budgets-au/budgets:0.326.0 and roll. No migrations. The visible changes are: $0.00 amounts render grey instead of green, negatives are slightly brighter in dark mode, font-mono text is actually monospace, and the Transactions bulk-selection bar stays on screen while you scroll.