Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit 8faada0
Author: Dean Lee <deanlee3@gmail.com>
Date:   Sun Apr 23 08:54:36 2023 +0800

    refactor CANParser to improve performance (commaai#795)

    * reduce the const of copying signal values in CANParser::query_latest

    * pass by reference

    * use for range loop

    * update_strings

    * use assign

    * track all signals

    * use iterator & pointer to avoid copy SignalValue from vector

    * use normal dict for vl_all

    * update tests

    * fix error in merge master

    * change thresholds

    reduce thresholds

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * cleanup ctor

    * reduce threshold

    * revert changes to test_parser.py

    * change thresholds

    * remove update_string() from cython

    * comment out test_performance_one_signal

    * reduce thresholds

    * test

    * update

    * update

    * revert that for now

    * update

    * update

    ---------

    Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

commit 5adb62b
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Fri Apr 21 13:11:53 2023 -0700

    fix parser perf test (commaai#827)

commit d40e429
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Apr 17 16:50:14 2023 -0700

    Subaru: more infotainment signals (commaai#823)

    * new infotainment sigs

    * better names

    * generate

    * another static bit signal (set on a forster)

    * generate

commit 9eec533
Author: Willem Melching <willem.melching@gmail.com>
Date:   Mon Apr 17 18:59:20 2023 +0200

    DBC parser: assert no duplicate signal names in msg (commaai#821)

    Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

commit b7546cd
Author: Willem Melching <willem.melching@gmail.com>
Date:   Mon Apr 17 18:56:43 2023 +0200

    remove duplicate signal names from Honda DBCs (commaai#822)

commit 7191f44
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sat Apr 15 23:18:45 2023 -0700

    CI: split up jobs + update requirements (commaai#819)

commit 003baff
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sat Apr 15 17:58:40 2023 -0700

    switch to pat

commit 613cd27
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sat Apr 15 17:47:34 2023 -0700

    CI: add job to update pre-commit hooks (commaai#817)

    * CI: add job to update pre-commit hooks

    * rm push trigger

commit 82779a8
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Apr 15 17:47:23 2023 -0700

    pre-commit: autoupdate hooks (commaai#818)

    Update pre-commit hook versions

    Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

commit 342c032
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date:   Sat Apr 15 14:17:46 2023 -0400

    VW MQB: Cleanup HCA control message (commaai#805)

    * VW MQB: Clean up HCA control message

    * enable checksum/counter, change scaling

    * fix mangled comment character encoding

commit 933d784
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Apr 14 02:31:17 2023 -0700

    Honda Radarless: add a cruise related signal (commaai#807)

    * add sigs

    * checksum and counter

commit f50e9d7
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Thu Apr 13 14:48:00 2023 -0700

    CANParser: add msg name to debug prints (commaai#813)

commit 3c81860
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sat Apr 8 15:36:23 2023 -0700

    test parser: bump up one signal threshold

commit f9837ff
Author: Justin Newberry <jnewberry0502@gmail.com>
Date:   Sat Apr 8 14:03:05 2023 -0400

    Subaru: add infotainment status message (commaai#809)

    * wip

    * forgot checksum and stuff

    * update

    * add blank filler

    * fix missing bit

    * fix missing bit

    * remove filler signals

    * convert toval

commit 8a3c9a7
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Apr 7 00:25:28 2023 -0700

    honda_civic_ex_2022: add BRAKE_MODULE (commaai#811)

    * add sigs

    * update

    * detection

commit 9c851fa
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sun Apr 2 10:41:42 2023 -0700

    CI: set PYTHONWARNINGS=error (commaai#806)

commit f01929f
Author: Dean Lee <deanlee3@gmail.com>
Date:   Sun Apr 2 22:45:51 2023 +0800

    CANParser: improve cython performance (commaai#802)

    * improve cython performance

    * change thresholds

    * Trigger CI

    * reduce threshold for test all signals

    * change

    * reduce min

    * change

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * change

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * change

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

    * Trigger CI

commit 9a1de83
Author: Dean Lee <deanlee3@gmail.com>
Date:   Sat Apr 1 04:51:14 2023 +0800

    CANParser: use emplace_back to reduce the cost of copying values (commaai#797)

commit 0ff2503
Author: Dean Lee <deanlee3@gmail.com>
Date:   Sat Apr 1 04:50:03 2023 +0800

    CANParser: add performance test (commaai#801)

    * add benchmarks

    * cleanup

    * unittest

    * thresholds

    * add test for update_strings

    * change thresholds

    * increase to 50000

    * trigger ci

    * update thresholds

    * trigger ci

    ---------

    Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

commit bb3bc2b
Author: FLcruising <86490693+FLcruising@users.noreply.github.com>
Date:   Thu Mar 30 14:36:13 2023 -0500

    VW PQ: corrections to EPB_1 (commaai#804)

    Fixes many messages, some of which are used as feedback to ACC and "Follow-to-Stop" function.

commit cc966f5
Author: Dean Lee <deanlee3@gmail.com>
Date:   Wed Mar 29 03:33:37 2023 +0800

    CANPacker: pass values by reference in cython (commaai#803)

commit 8c5f9c4
Author: Seonghoon Jeong <seonghoon@shjeong.net>
Date:   Tue Mar 28 16:34:17 2023 +0900

    hyundai_2015_ccan.dbc: fix signal scale (commaai#732)

    Update hyundai_2015_ccan.dbc

    The scale of signal `CF_Ems_IsgStat2` should be 1.0 instead of 2.0 because two bits are assigned for the signal. Otherwise, the range of the signal must be [0.0|6.0] rather than [0.0|3.0].

commit 636a61b
Author: rusefillc <48498823+rusefillc@users.noreply.github.com>
Date:   Mon Mar 27 19:19:03 2023 -0400

    More on Nissan (commaai#746)

    * More on Nissan

    * Nissan progress

    * Nissan progress

    * Torque?!

    * Nissan progress

    ---------

    Co-authored-by: rusefillc <sdfsdfqsf2334234234>

commit 1f0e04f
Author: Dean Lee <deanlee3@gmail.com>
Date:   Tue Mar 28 07:01:39 2023 +0800

    libdbc: build both static and shared library (commaai#786)

commit ee9f7e6
Author: Willem Melching <willem.melching@gmail.com>
Date:   Mon Mar 27 20:48:45 2023 +0200

    dbc.cc: put check for duplicate message name behind flag (commaai#800)

commit 21b8f28
Author: Eric Brown <eric@ebrown.net>
Date:   Sun Mar 26 18:14:30 2023 -0600

    GM: Add single pedal mode signals for Bolt EV/EUV (commaai#789)

commit b79b8f5
Author: Dean Lee <deanlee3@gmail.com>
Date:   Mon Mar 27 08:02:27 2023 +0800

    CANParser: pass string by referer (commaai#796)

commit f1479b3
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Mar 24 17:37:37 2023 -0700

    Toyota: add brake pressed bits (commaai#794)

    * add brake pressed sigs

    * generate

commit b7d4a6e
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date:   Mon Mar 13 17:12:51 2023 -0400

    VW PQ: Misc corrections in ACC_GRA_Anzeige (commaai#792)

commit ef06eab
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date:   Mon Mar 13 16:16:53 2023 -0400

    VW PQ: Corrected scaling/offsets in Motor_Bremse (commaai#790)

    VW PQ: Corrected brake command scaling

commit 21c42e0
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date:   Mon Mar 13 16:16:38 2023 -0400

    VW PQ: Corrected scaling/offsets in ACC_System (commaai#791)

    * VW PQ: Corrected scaling/offsets in ACC_System

    * add values

commit 21457f0
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Feb 20 15:19:05 2023 -0800

    CANParser: ts_nanos test (commaai#785)

    * ts_nanos tests

    * check set is length 1

    * same style as below

commit 510bfc0
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Feb 10 23:44:17 2023 -0800

    GM: add friction brake unavailable signal (commaai#782)

    * Add friction brake unavailable signal

    * add comment

commit 6eab6cf
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Feb 10 15:22:58 2023 -0800

    Chrysler: add temporary EPS fault bit (commaai#781)

    Add temporary EPS fault bit

commit 2922a05
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Feb 10 14:46:35 2023 -0800

    GM: add a cluster speed signal (commaai#780)

    * Add cluster speed signal

    * add the counter

    * add comment

    * gen

commit d103b15
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Feb 7 23:00:22 2023 -0800

    CANParser: add timestamp field (commaai#779)

    * add timestamp back, logMonoTime

    * rename ts_nanos

commit 0b7439f
Author: Cameron Clough <cameronjclough@gmail.com>
Date:   Thu Feb 2 20:05:52 2023 -0800

    Ford: rename TrnRng_D_RqGsm Sport value (commaai#778)

commit 1d898eb
Author: Louie Lu <git@louie.lu>
Date:   Sun Jan 22 16:19:21 2023 -0500

    Mazda: add MRCC vehicle ahead distance on gauge (commaai#771)

commit 2a186ec
Author: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com>
Date:   Thu Jan 12 01:26:08 2023 -0500

    HKG CAN-FD: Second alternate GEAR message (commaai#768)

    * Second alternate GEAR message

    * Wrong bits!

    * 32 bytes

commit bd3ce2d
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jan 10 21:18:16 2023 -0800

    HKG CAN-FD: Rename reversing signal in BLINDSPOTS_FRONT_CORNER_1 (commaai#770)

    Update hyundai_canfd.dbc

commit a10e7ce
Author: royjr <royjr96@gmail.com>
Date:   Wed Jan 11 00:00:42 2023 -0500

    Honda Civic 2022: Rename CONTROL_OFF -> IDLESTOP_ALLOW (commaai#776)

    * CONTROL_OFF -> IDLESTOP_ALLOW

    This tells the car its ready to turn off the engine, which does so when the car is standstill.

    * update comment

    update comment

    Co-authored-by: Shane Smiskol <shane@smiskol.com>

commit d585a9b
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Jan 2 16:10:04 2023 -0800

    Hyundai CAN-FD: SCC upper jerk limit signal (commaai#775)

    upper jerk

commit 107b96a
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sun Jan 1 17:09:27 2023 -0800

    add some type hints (commaai#774)

    * type stubs for common, parser_pyx

    * Cleanup imports

    * values are indeed floats

    * common.pyi complete, added cpp stubs

    * parser_pyx.pyi complete

    * CANPacker completed

    * Holding temp changes...

    * remove *.pyi

    * just remove skip-file

    Co-authored-by: Jason Shuler <jshuler@gmail.com>

commit dcab27c
Author: Greg Hogan <gregjhogan@gmail.com>
Date:   Sun Jan 1 16:10:26 2023 -0800

    toyota: update CAR_MOVEMENT and ODOMETER signal (commaai#748)

commit 28f78f3
Author: Louie Lu <git@louie.lu>
Date:   Sun Jan 1 19:09:34 2023 -0500

    Mazda: Add vehicle acceleration of x and y axis (NED) (commaai#767)

commit 06a3e7d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sat Dec 31 16:49:26 2022 -0800

    add cpplint (commaai#773)

    * add cpplint

    * passes

    * bump cereal

    * here's a real hash

commit e8e97fc
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Dec 15 15:19:11 2022 -0800

    Bump pylint to 2.15.4 (commaai#765)

    bump

commit 119f3f6
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Dec 15 13:16:57 2022 -0800

    Bump pylint version (commaai#764)

    bump pylint

commit 4a7ad63
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Dec 12 23:04:12 2022 -0800

    HKG CAN-FD: add brake error signal (commaai#762)

    * add brake errors

    * rename and add comment

    * fix

commit bb71829
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Dec 12 17:10:47 2022 -0800

    GM: add comment for ACCAlwaysOne

commit 38fe4d3
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Dec 12 17:03:36 2022 -0800

    GM: add steering buttons ACC-related bit (commaai#761)

    * add missing acc bit

    * this just looks better

commit 1f8aa05
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Dec 8 20:35:26 2022 -0800

    Toyota: update LTA signals (commaai#759)

    * si

    * fix comments

    * run generator

    * Revert "run generator"

    This reverts commit 2b67e4c.

    Revert "fix comments"

    This reverts commit 7f95fd2.

    Revert "si"

    This reverts commit f058760.

    * sort and add LKA_ACTIVE signal (also flip STEER_REQUEST and _2)

    * Revert "sort and add LKA_ACTIVE signal (also flip STEER_REQUEST and _2)"

    This reverts commit 4ffd0f2.

    * minimal changes

    * run generator

commit fae2238
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Dec 7 15:13:14 2022 -0800

    more canfd hkg blinker signals

commit 94fff47
Author: Shane Smiskol <shane@smiskol.com>
Date:   Sat Dec 3 02:02:55 2022 -0800

    Toyota: add steer_unavailable EPS states (commaai#756)

    * add lxa_unavailable states

    * generate

    * better to be more descriptive

    * better

commit 18e4ceb
Author: Shane Smiskol <shane@smiskol.com>
Date:   Sat Dec 3 00:39:47 2022 -0800

    Toyota: fix ACC fault signal comment (commaai#755)

    better name and comment

commit 4e3899c
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Dec 2 21:02:00 2022 -0800

    Toyota: add ACC faulted signals (commaai#754)

    * add acc faulted signal to toyota dbc

    * generate

commit 3737675
Author: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com>
Date:   Thu Dec 1 17:21:27 2022 -0500

    HKG: Additional Distance Unit Signal (commaai#753)

    HKG: Car Port for Kia Sorento Plug-in Hybrid 2022

commit 900d8d1
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Nov 28 21:41:29 2022 -0800

    Hyundai: CAN-FD RSPAS messages (commaai#752)

    * Hyundai: CAN-FD RSPAS messages

    * fix checksum

commit 871e054
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Nov 22 14:57:13 2022 -0800

    GM: add cruise state signal (commaai#750)

    * add cruise state signal

    * values

    * accurate

commit cb53738
Author: Cameron Clough <cameronjclough@gmail.com>
Date:   Mon Nov 21 00:08:22 2022 -0800

    update README link to cabana

    closes commaai#733

commit 16efea3
Author: Willem Melching <willem.melching@gmail.com>
Date:   Tue Nov 15 19:51:42 2022 +0100

    add missing iterator include (commaai#747)

commit 296f190
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Nov 2 16:17:20 2022 -0700

    GM: add bits for moving backwards (commaai#737)

    add bits for moving forward/backwards

commit 2304ecf
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Nov 2 15:39:33 2022 -0700

    GM: add new undefined brake-related signals (commaai#736)

    * add some more brake related signals i found

    * generate

    * standardize name

    * add comments

    * generate

    * fix signal definition

commit 909e650
Author: ioniq5-cz <111085918+ioniq5-cz@users.noreply.github.com>
Date:   Mon Oct 31 22:02:35 2022 +0100

    CAN-FD HKG - Secondary Speed Limit, Schoolzone and bugfix (commaai#735)

    Secondary Speed Limit, Schoolzone and bugfix

commit b3dc569
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sun Oct 30 17:57:29 2022 -0700

    EV6 longitudinal signals (commaai#734)

    * match to can platform

    * more matching

    * little more

commit 063f70a
Author: ioniq5-cz <111085918+ioniq5-cz@users.noreply.github.com>
Date:   Sat Oct 29 21:47:01 2022 +0200

    CAN-FD HGK - additional icons and chime from cars dash (commaai#728)

    additional Icons and chime from Dash

commit 526e21d
Author: ioniq5-cz <111085918+ioniq5-cz@users.noreply.github.com>
Date:   Fri Oct 28 21:42:39 2022 +0200

    Hyundai CAN-FD: fix set speed signal size (commaai#729)

    * additional Icons and chime from Dash

    * Fix for EU cars using kph with 127 limit

    * 255 max

    * remove factor 0.5

    * removing unused NEW_SIGNAL_4 on 103

commit bf30c91
Author: ioniq5-cz <111085918+ioniq5-cz@users.noreply.github.com>
Date:   Tue Oct 25 08:05:52 2022 +0200

    CAN-FD HKG - Speed Limits from Dashboard (commaai#727)

    * SPEED_LIMITS HDA2 Dash

    * cleanup

    * cleanup 2

    * Final Adjustments

    * cleanup

    * cleanup 2

    * clean title for HDA2

    * change title since it covers hda 1 and 2

commit a95b0ae
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Oct 24 19:15:26 2022 -0700

    ev6 blindspot signals

commit e111117
Author: Brandon Smyth <bjsmyth@umich.edu>
Date:   Mon Oct 24 19:23:43 2022 -0400

    Ford: correct syntax error (commaai#720)

    Correct syntax error

    Co-authored-by: Brandon <brandon@Weston.local>

commit d1dffa1
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Sun Oct 23 17:34:46 2022 -0700

    unpin scons

commit 4e9acc8
Author: Jiapeng Li <gapleehit@gmail.com>
Date:   Fri Oct 21 11:08:47 2022 +0800

    [docker] rm cereal .git folder (commaai#721)

    * [docker] rm cereal .git folder

    * Update Dockerfile

    Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

commit 7bd94e3
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Oct 20 19:28:28 2022 -0700

    HKG CAN-FD: rename common brake signal (commaai#725)

    * rename brake signals

    * move

    * fix

    * add comments

commit 1903dc5
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Oct 20 15:36:44 2022 -0700

    HKG CAN-FD: BRAKE_POSITION is signed (commaai#724)

    * signed

    * cmt

commit 27022cc
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Oct 20 14:31:00 2022 -0700

    HKG CAN-FD: rename brake pressure signal, add position signal (commaai#723)

    * add brake percent/pressure

    * This are actually swapped

    * add comments

commit a58a58a
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Oct 19 21:50:34 2022 -0700

    Hyundai CAN-FD: a few TCS signals (commaai#722)

commit 8a37db4
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Oct 19 11:15:19 2022 -0700

    EV6 corner radars (commaai#719)

    * ev6 blindspot radars

    * Update hyundai_canfd.dbc

commit 8f245e6
Author: Eric Day <smartype@gmail.com>
Date:   Tue Oct 18 12:27:50 2022 +0800

    Toyota: radar dsu tss-p radar support, aka nodsu (commaai#707)

    * Toyota: radar dsu tss-p radar support, aka nodsu

    * update LONG_DIST factor to 0.03

commit ad45ef8
Author: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com>
Date:   Tue Oct 18 00:25:46 2022 -0400

    Hyundai CAN-FD: support for ICE cars (commaai#680)

    * Hyundai: Car Port for Santa Cruz 2022

    * Define gears

    * Wrong definition

commit c131dce
Author: Dean Lee <deanlee3@gmail.com>
Date:   Tue Oct 18 12:25:13 2022 +0800

    CANParser: parse DBC from stream (commaai#718)

commit dde0ff6
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date:   Wed Oct 12 19:26:00 2022 -0400

    VW MQB: Update ACC messages (commaai#717)

    * add/update ACC messages

    * lower diff

commit 04cc54d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Tue Oct 11 18:46:02 2022 -0700

    EV6 radar + longitudinal messages (commaai#714)

    * EV6 radar messages

    * fix radar messages

    * adrv messages

    * start adrv

    * one more

    * it's on both, but don't want to split the dbc yet

    * and the signals

    * accel signals

    * little more

    * few more

    * getting somewhere

commit a70a900
Author: Greg Hogan <gregjhogan@gmail.com>
Date:   Tue Oct 11 16:04:19 2022 -0700

    Hyundai corner radar DBC (commaai#712)

    * corner radar dbc based on palisade

    * 0x100/0x200 scale/offset

    * update DBC

    * generate dbc properly

commit c35e813
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Oct 10 23:04:08 2022 -0700

    HKG CAN-FD: add LKA fault signal (commaai#716)

    * Add LKA fault signal

    * add comment

    * change to 1 bit

commit 0c80dc3
Author: Shane Smiskol <shane@smiskol.com>
Date:   Sat Oct 8 22:14:50 2022 -0700

    Add missing checksum and counter signals for PSCMStatus (commaai#715)

    * Add missing checksum and counter signals for PSCMStatus

    * flip

commit c090e49
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Fri Oct 7 17:12:17 2022 -0700

    Revert "EV6 radar messages"

    This reverts commit b3be6e9.

commit b3be6e9
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Fri Oct 7 17:03:24 2022 -0700

    EV6 radar messages

commit 6fc6781
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Oct 7 15:50:33 2022 -0700

    Add comment about variable length GM message, fix comment syntax

commit ae2fd93
Author: Cameron Clough <cameronjclough@gmail.com>
Date:   Wed Oct 5 19:42:01 2022 -0700

    Revert "Ford: fix steering command signal ranges (commaai#683)"

    This reverts commit 778894f.

commit 9ddcdb2
Author: Greg Hogan <gregjhogan@gmail.com>
Date:   Mon Oct 3 18:43:26 2022 -0700

    hyundai: fix FCA11 checksum and counter (commaai#656)

commit 3a03644
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Oct 3 14:27:27 2022 -0700

    hyundai_kia_generic: add values for ACCEnable signal

commit 738e8aa
Author: Greg Hogan <gregjhogan@gmail.com>
Date:   Sun Sep 25 08:31:57 2022 -0700

    CAN-FD messages can be 64 bytes (commaai#711)

commit eaac172
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Sep 21 21:40:31 2022 -0700

    setup generator for hyundai radar dbc (commaai#710)

    * setup generator for hyundai radar dbc

    * fix indentation

commit 1f47ae8
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Sep 19 11:48:09 2022 -0700

    Honda Bosch Radarless: add standstill bit (commaai#699)

    * Update honda_civic_ex_2022_can.dbc

    * Update honda_civic_ex_2022_can.dbc

    * run generator

commit 3008f67
Author: Greg Hogan <gregjhogan@gmail.com>
Date:   Sat Sep 17 16:02:44 2022 -0700

    hyundai: fix CAN-FD steering angle rate signal (commaai#708)

    * hyundai: fix canfd steering angle rate signal

    * make consistent with non-canfd definition

commit 82435e5
Author: ioniq5-cz <111085918+ioniq5-cz@users.noreply.github.com>
Date:   Thu Sep 8 21:28:07 2022 +0200

    Hyundai: Add FCA signal for CAN-FD (commaai#706)

    * new signal for FCA detection IONIQ 5 HDA2

    * Cleanup

    * cleanup

    * cleanup2

commit e95ed31
Author: martinl <martin@mlp.ee>
Date:   Thu Sep 8 06:37:36 2022 +0300

    Add test for Subaru Brake_Status Signal1 large value (commaai#702)

    * Add test for Subaru Brake_Status Signal1 large value

    * fix

    Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

commit 40c6132
Author: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com>
Date:   Wed Sep 7 16:43:01 2022 -0400

    Hyundai: Add Manumatic/Paddle Shifter signal (commaai#705)

commit d588872
Author: Comma Device <device@comma.ai>
Date:   Fri Sep 2 19:00:25 2022 -0400

    can parser: reduce spammy debug messages

commit 83d4cb9
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Aug 31 15:17:08 2022 -0700

    fix typo

commit 8a60d0d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Wed Aug 31 15:01:27 2022 -0700

    hyundai canfd: add a couple brake signals

commit 63581cc
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Aug 29 22:59:48 2022 -0700

    Toyota: add universal units signal (commaai#695)

    * Toyota: add universal units signal

    * not vehicle units

    * Update comment

    * Update comment 2

    * Update comment 2

    * Update signal name for RC and IS

commit 778894f
Author: Cameron Clough <cameronjclough@gmail.com>
Date:   Mon Aug 29 14:02:03 2022 -0700

    Ford: fix steering command signal ranges (commaai#683)

    fix LatCtlPath_An_Actl signal range

commit d8e7566
Author: Cameron Clough <cameronjclough@gmail.com>
Date:   Mon Aug 29 13:46:28 2022 -0700

    ford: another mystery bit (commaai#697)

    Found another signal to passthrough
  • Loading branch information
budney committed May 5, 2023
1 parent 04f9e6b commit 8bb9068
Show file tree
Hide file tree
Showing 59 changed files with 574 additions and 192 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/repo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: repo

on:
schedule:
- cron: "0 15 * * 2"
workflow_dispatch:

jobs:
pre-commit-autoupdate:
name: pre-commit autoupdate
runs-on: ubuntu-20.04
container:
image: ghcr.io/commaai/opendbc:latest
steps:
- uses: actions/checkout@v3
- name: pre-commit autoupdate
run: |
git config --global --add safe.directory '*'
pre-commit autoupdate
- name: Create Pull Request
uses: peter-evans/create-pull-request@5b4a9f6a9e2af26e5f02351490b90d01eb8ec1e5
with:
token: ${{ secrets.ACTIONS_CREATE_PR_PAT }}
commit-message: Update pre-commit hook versions
title: 'pre-commit: autoupdate hooks'
branch: pre-commit-updates
base: master
delete-branch: true
63 changes: 43 additions & 20 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,55 @@ name: tests
on: [push, pull_request]

env:
RUN: docker run --shm-size 1G --rm opendbc /bin/sh -c
RUN: docker run -v $GITHUB_WORKSPACE:/project/opendbc -w /project/opendbc -e PYTHONWARNINGS=error --shm-size 1G --rm opendbc /bin/bash -c
BUILD: |
docker pull $(grep -ioP '(?<=^from)\s+\S+' Dockerfile) || true
docker pull ghcr.io/commaai/opendbc:latest || true
docker build --cache-from ghcr.io/commaai/opendbc:latest -t opendbc -f Dockerfile .
PYTHONWARNINGS: error

jobs:
test:
unit-tests:
name: unit tests
runs-on: ubuntu-20.04
#strategy:
# fail-fast: false
# matrix:
# run: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14]
steps:
- uses: actions/checkout@v2
- name: Build Docker image
run: eval "$BUILD"
- name: Static analysis
run: |
docker run opendbc bash -c "cd opendbc && git init && git add -A && pre-commit run --all"
- name: Generator test
run: |
docker run opendbc bash -c "cd opendbc/generator && ./test_generator.py"
- name: Unit tests
run: |
docker run opendbc bash -c "python -m unittest discover opendbc"
- name: Push to dockerhub
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/opendbc'
run: |
docker login ghcr.io -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }}
docker tag opendbc ghcr.io/commaai/opendbc:latest
docker push ghcr.io/commaai/opendbc:latest
- uses: actions/checkout@v3
- name: Build Docker image
run: eval "$BUILD"
- name: Build opendbc
run: ${{ env.RUN }} "cd ../ && scons -j$(nproc)"
- name: Unit tests
run: ${{ env.RUN }} "python -m unittest discover ."

static-analysis:
name: static analysis
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- name: Build Docker image
run: eval "$BUILD"
- name: Build opendbc
run: ${{ env.RUN }} "cd ../ && scons -j$(nproc)"
- name: pre-commit
# TODO: a package pre-commit installs has a warning, remove the unset once that's fixed
run: ${{ env.RUN }} "unset PYTHONWARNINGS && pre-commit run --all"
- name: Generator test
run: ${{ env.RUN }} "generator/test_generator.py"

docker-push:
name: docker push
runs-on: ubuntu-20.04
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/opendbc'
steps:
- uses: actions/checkout@v3
- name: Build Docker image
run: eval "$BUILD"
- name: Push to dockerhub
run: |
docker login ghcr.io -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }}
docker tag opendbc ghcr.io/commaai/opendbc:latest
docker push ghcr.io/commaai/opendbc:latest
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
.sconsign.dblite

can/*.so
can/*.a
can/build/
can/obj/
can/packer_pyx.cpp
Expand Down
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.3.0
rev: v4.4.0
hooks:
- id: check-ast
- id: check-yaml
- id: check-merge-conflict
- id: check-symlinks
- repo: https://github.com/codespell-project/codespell
rev: v2.2.1
rev: v2.2.4
hooks:
- id: codespell
exclude: '\.dbc$'
args:
- --check-hidden
- --builtins clear,rare,informal,usage,code,names,en-GB_to_en-US
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.971
rev: v1.2.0
hooks:
- id: mypy
- repo: https://github.com/PyCQA/flake8
rev: 5.0.4
rev: 6.0.0
hooks:
- id: flake8
exclude: 'site_scons/'
Expand Down
12 changes: 5 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,14 @@ RUN pip install --no-cache-dir pre-commit==2.15.0 pylint==2.5.2

ENV PYTHONPATH=/project

RUN git config --global --add safe.directory '*'

WORKDIR /project
# TODO: Add tag to cereal
RUN git clone https://github.com/commaai/cereal.git /project/cereal && \
cd /project/cereal && \
git checkout 959ff79963b80829be9902d146c31fda44dbbd20
git checkout 959ff79963b80829be9902d146c31fda44dbbd20 && \
rm -rf .git && \
scons -j$(nproc)

COPY SConstruct .
COPY ./site_scons /project/site_scons
COPY . /project/opendbc

RUN rm -rf /project/opendbc/.git && \
rm -rf /project/cereal/.git
RUN scons -c && scons -j$(nproc)
2 changes: 1 addition & 1 deletion acura_ilx_2016_can_generated.dbc
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ BO_ 829 LKAS_HUD: 5 ADAS
SG_ SOLID_LANES : 10|1@0+ (1,0) [0|1] "" BDY
SG_ LDW_RIGHT : 9|1@0+ (1,0) [0|1] "" BDY
SG_ STEERING_REQUIRED : 8|1@0+ (1,0) [0|1] "" BDY
SG_ BOH : 23|2@0+ (1,0) [0|4] "" BDY
SG_ BOH_2 : 23|2@0+ (1,0) [0|4] "" BDY
SG_ LDW_PROBLEM : 21|1@0+ (1,0) [0|1] "" BDY
SG_ BEEP : 17|2@0+ (1,0) [0|1] "" BDY
SG_ LDW_ON : 28|1@0+ (1,0) [0|1] "" BDY
Expand Down
2 changes: 1 addition & 1 deletion acura_rdx_2018_can_generated.dbc
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ BO_ 829 LKAS_HUD: 5 ADAS
SG_ SOLID_LANES : 10|1@0+ (1,0) [0|1] "" BDY
SG_ LDW_RIGHT : 9|1@0+ (1,0) [0|1] "" BDY
SG_ STEERING_REQUIRED : 8|1@0+ (1,0) [0|1] "" BDY
SG_ BOH : 23|2@0+ (1,0) [0|4] "" BDY
SG_ BOH_2 : 23|2@0+ (1,0) [0|4] "" BDY
SG_ LDW_PROBLEM : 21|1@0+ (1,0) [0|1] "" BDY
SG_ BEEP : 17|2@0+ (1,0) [0|1] "" BDY
SG_ LDW_ON : 28|1@0+ (1,0) [0|1] "" BDY
Expand Down
6 changes: 3 additions & 3 deletions acura_rdx_2020_can_generated.dbc
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ BO_ 13274 LKAS_HUD_A: 5 ADAS
SG_ SOLID_LANES : 10|1@0+ (1,0) [0|1] "" BDY
SG_ LDW_RIGHT : 9|1@0+ (1,0) [0|1] "" BDY
SG_ STEERING_REQUIRED : 8|1@0+ (1,0) [0|1] "" BDY
SG_ BOH : 23|2@0+ (1,0) [0|4] "" BDY
SG_ BOH_2 : 23|2@0+ (1,0) [0|4] "" BDY
SG_ LDW_PROBLEM : 21|1@0+ (1,0) [0|1] "" BDY
SG_ BEEP : 17|2@0+ (1,0) [0|1] "" BDY
SG_ SET_ME_X01 : 20|1@0+ (1,0) [0|1] "" BDY
Expand All @@ -378,7 +378,7 @@ BO_ 13275 LKAS_HUD_B: 8 ADAS
SG_ SOLID_LANES : 10|1@0+ (1,0) [0|1] "" BDY
SG_ LDW_RIGHT : 9|1@0+ (1,0) [0|1] "" BDY
SG_ STEERING_REQUIRED : 8|1@0+ (1,0) [0|1] "" BDY
SG_ BOH : 23|2@0+ (1,0) [0|4] "" BDY
SG_ BOH_2 : 23|2@0+ (1,0) [0|4] "" BDY
SG_ LDW_PROBLEM : 21|1@0+ (1,0) [0|1] "" BDY
SG_ BEEP : 17|2@0+ (1,0) [0|1] "" BDY
SG_ SET_ME_X01 : 20|1@0+ (1,0) [0|1] "" BDY
Expand Down Expand Up @@ -436,7 +436,7 @@ BO_ 829 LKAS_HUD: 5 ADAS
SG_ SOLID_LANES : 10|1@0+ (1,0) [0|1] "" BDY
SG_ LDW_RIGHT : 9|1@0+ (1,0) [0|1] "" BDY
SG_ STEERING_REQUIRED : 8|1@0+ (1,0) [0|1] "" BDY
SG_ BOH : 23|2@0+ (1,0) [0|4] "" BDY
SG_ BOH_2 : 23|2@0+ (1,0) [0|4] "" BDY
SG_ LDW_PROBLEM : 21|1@0+ (1,0) [0|1] "" BDY
SG_ BEEP : 17|2@0+ (1,0) [0|1] "" BDY
SG_ LDW_ON : 28|1@0+ (1,0) [0|1] "" BDY
Expand Down
9 changes: 8 additions & 1 deletion can/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ import os
envDBC = env.Clone()
dbc_file_path = '-DDBC_FILE_PATH=\'"%s"\'' % (envDBC.Dir("..").abspath)
envDBC['CXXFLAGS'] += [dbc_file_path]
libdbc = envDBC.SharedLibrary('libdbc', ["dbc.cc", "parser.cc", "packer.cc", "common.cc"], LIBS=[common, "capnp", "kj", "zmq"])
src = ["dbc.cc", "parser.cc", "packer.cc", "common.cc"]
libs = [common, "capnp", "kj", "zmq"]

# shared library for openpilot
libdbc = envDBC.SharedLibrary('libdbc', src, LIBS=libs)

# static library for tools like cabana
envDBC.Library('libdbc_static', src, LIBS=libs)

# Build packer and parser
lenv = envCython.Clone()
Expand Down
4 changes: 3 additions & 1 deletion can/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ unsigned int pedal_checksum(uint32_t address, const Signal &sig, const std::vect

class MessageState {
public:
std::string name;
uint32_t address;
unsigned int size;

Expand Down Expand Up @@ -80,11 +81,12 @@ class CANParser {
CANParser(int abus, const std::string& dbc_name, bool ignore_checksum, bool ignore_counter);
#ifndef DYNAMIC_CAPNP
void update_string(const std::string &data, bool sendcan);
void update_strings(const std::vector<std::string> &data, std::vector<SignalValue> &vals, bool sendcan);
void UpdateCans(uint64_t sec, const capnp::List<cereal::CanData>::Reader& cans);
#endif
void UpdateCans(uint64_t sec, const capnp::DynamicStruct::Reader& cans);
void UpdateValid(uint64_t sec);
std::vector<SignalValue> query_latest();
void query_latest(std::vector<SignalValue> &vals, uint64_t last_ts = 0);
};

class CANPacker {
Expand Down
6 changes: 3 additions & 3 deletions can/common.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ cdef extern from "common_dbc.h":

cdef struct SignalValue:
uint32_t address
uint64_t ts_nanos
string name
double value
vector[double] all_values
Expand All @@ -77,9 +78,8 @@ cdef extern from "common.h":
bool can_valid
bool bus_timeout
CANParser(int, string, vector[MessageParseOptions], vector[SignalParseOptions])
void update_string(string, bool)
vector[SignalValue] query_latest()
void update_strings(vector[string]&, vector[SignalValue]&, bool)

cdef cppclass CANPacker:
CANPacker(string)
vector[uint8_t] pack(uint32_t, vector[SignalPackValue])
vector[uint8_t] pack(uint32_t, vector[SignalPackValue]&)
3 changes: 2 additions & 1 deletion can/common_dbc.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ struct MessageParseOptions {

struct SignalValue {
uint32_t address;
uint64_t ts_nanos;
std::string name;
double value; // latest value
std::vector<double> all_values; // all values from this cycle
Expand Down Expand Up @@ -83,6 +84,6 @@ typedef struct ChecksumState {
} ChecksumState;

DBC* dbc_parse(const std::string& dbc_path);
DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, ChecksumState *checksum = nullptr);
DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, ChecksumState *checksum = nullptr, bool allow_duplicate_msg_name=false);
const DBC* dbc_lookup(const std::string& dbc_name);
std::vector<std::string> get_dbc_names();
14 changes: 11 additions & 3 deletions can/dbc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ void set_signal_type(Signal& s, ChecksumState* chk, const std::string& dbc_name,
}
}

DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, ChecksumState *checksum) {
DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, ChecksumState *checksum, bool allow_duplicate_msg_name) {
uint32_t address = 0;
std::set<uint32_t> address_set;
std::set<std::string> msg_name_set;
std::map<uint32_t, std::set<std::string>> signal_name_sets;
std::map<uint32_t, std::vector<Signal>> signals;
DBC* dbc = new DBC;
dbc->name = dbc_name;
Expand Down Expand Up @@ -134,8 +135,11 @@ DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, Ch
// check for duplicates
DBC_ASSERT(address_set.find(address) == address_set.end(), "Duplicate message address: " << address << " (" << msg.name << ")");
address_set.insert(address);
DBC_ASSERT(msg_name_set.find(msg.name) == msg_name_set.end(), "Duplicate message name: " << msg.name);
msg_name_set.insert(msg.name);

if (!allow_duplicate_msg_name) {
DBC_ASSERT(msg_name_set.find(msg.name) == msg_name_set.end(), "Duplicate message name: " << msg.name);
msg_name_set.insert(msg.name);
}
} else if (startswith(line, "SG_ ")) {
// new signal
int offset = 0;
Expand All @@ -162,6 +166,10 @@ DBC* dbc_parse_from_stream(const std::string &dbc_name, std::istream &stream, Ch
sig.msb = sig.start_bit;
}
DBC_ASSERT(sig.lsb < (64 * 8) && sig.msb < (64 * 8), "Signal out of bounds: " << line);

// Check for duplicate signal names
DBC_ASSERT(signal_name_sets[address].find(sig.name) == signal_name_sets[address].end(), "Duplicate signal name: " << sig.name);
signal_name_sets[address].insert(sig.name);
} else if (startswith(line, "VAL_ ")) {
// new signal value/definition
bool ret = std::regex_search(line, match, val_regexp);
Expand Down
Loading

0 comments on commit 8bb9068

Please sign in to comment.