Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guild): implement onboarding #1401

Merged
merged 21 commits into from Jan 1, 2024

Conversation

Earlopain
Copy link
Contributor

Adds support for inspecting the onboarding configuration of a guild.

https://discord.com/developers/docs/resources/guild#guild-onboarding-object

I want to know which roles are assignable by users through onboarding, which this is needed for.

@FedorLap2006 FedorLap2006 added meta Documentation and examples related issues and pull requests feature Feature implementation rest REST API related issues and pull requests structs API structs and constants related changes and removed meta Documentation and examples related issues and pull requests labels Jul 1, 2023
@FedorLap2006
Copy link
Collaborator

I could have done a rebase, but whatever 😅

Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, changes are good to go, however, a few tweaks are required.

restapi.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
@Earlopain
Copy link
Contributor Author

Thanks for the feedback, I appreciate your time on this. I'm currently on vacation and will get to it in a week or two.

FedorLap2006 and others added 2 commits July 15, 2023 18:31
Add constants defining onboarding modes and Mode field to GuildOnboarding.
@Earlopain
Copy link
Contributor Author

I should now have addressed all your feedback.

restapi.go Show resolved Hide resolved
structs.go Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
Earlopain and others added 2 commits August 10, 2023 11:41
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@FedorLap2006 FedorLap2006 added the high priority Issue or PR with high priority of merge label Aug 12, 2023
@FedorLap2006 FedorLap2006 added this to the v0.28.0 milestone Aug 16, 2023
Make Prompts field a pointer to allow removing all the prompts.
Use GuildOnboardingMode type in GuildOnboardingModeDefault and GuildOnboardingModeAdvanced.
@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Oct 14, 2023

Sorry it took so long! Decided to make some of the changes myself, hopefully you don't mind.

@FedorLap2006 FedorLap2006 force-pushed the guild-onboarding branch 6 times, most recently from 6534548 to bbc87b0 Compare October 28, 2023 01:52
@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Jan 1, 2024

decided to make some of the changes myself

Well, a lot of changes. Want to merge this into the next release I'm going to make soon. So decided to take it upon myself to finish the PR.

@FedorLap2006 FedorLap2006 changed the title feat(guild): add onboarding feat(guild): implement onboarding Jan 1, 2024
@FedorLap2006 FedorLap2006 merged commit 30b2cf2 into bwmarrin:master Jan 1, 2024
8 checks passed
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@Earlopain Earlopain deleted the guild-onboarding branch January 1, 2024 08:57
@Earlopain
Copy link
Contributor Author

Much appreciated for pushing this over the finish line. My bad for not keeping up here but I pretty quickly found another way to better achieve what I wanted through role flags (#1410) so this wasn't as relevant to me anymore.

Very nice to hear about a potential new release soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature implementation high priority Issue or PR with high priority of merge rest REST API related issues and pull requests structs API structs and constants related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants