Enhance GC subtyping checks #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest GC spec proposal has changed a lot since we implemented the feature, refactor it based on the main branch. Part of the spec cases were tested.
Implement GC for fast interpreter except struct/array related opcodes
And fix compile warning in wasm_c_api.c from wasm_table_get. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
- Add cmake variable `WAMR_BUILD_GC_BINARYEN` - Implement GC opcode array.copy - Fix bug in wasm_type_is_supers_of - Fix loader load import global and wasm_loader_pop_frame_ref - Support pass/return GC ref type params/result to/from native API
Change `wasm_obj_t *gc_obj` to `wasm_obj_t gc_obj`
…2184) And add comments for the GC export APIs
Merge branch main into dev/gc_refactor
- don't mark non-ref array elements - trace ref returned from native function - fix calculated array element offset error in reclaim_instance_heap
The runtime instance memory layout changed when GC was enabled. With this patch the GC is enabled for wamrc, but it keeps the compatibility with iwasm no matter GC is enabled for it or not. It may waste some memory for iwasm without GC support since the GC relative fields for the table instance are always here, let's optimization it after AOT fully supports GC.
- Set gc func type's quick_aot_entry - Call quick_aot_entry when hw bound check is disabled - Declare detailed aot func's prototype inside the quick aot entry - Remove ret_type in the quick aot entry - Update docker image
- Emit SIMD/ref-types/bulk-memory flags into AOT file only when the features are really used in wasm file - Remove unused tail-call flag and stringref flag - Add memoy64 flag and dynamic-linking flag - Change WASM_FEATURE_THREADS to WASM_FEATURE_MULTI_THREAD
…alliance#3117) Add wasm_runtime_get_cur_local_obj_ref and change API: ```C wasm_runtime_push_local_object_ref wasm_runtime_pop_local_object_ref wasm_runtime_pop_local_object_refs ``` to ```C wasm_runtime_push_local_obj_ref wasm_runtime_pop_local_obj_ref wasm_runtime_pop_local_obj_refs ``` Signed-off-by: zhangliangyu3 <zhangliangyu3@xiaomi.com>
…ne info of wasm src (bytecodealliance#3128) Implement the tool to convert the bytecode offset (address) in call-stack dump into to the line info in wasm source code.
Remove `JIT_STACK_FRAME` cmake variable and compilation macro, and use `AOT_STACK_FRAME` instead, to avoid introducing too many macros. Same as using `WASM_ENABLE_QUICK_AOT_ENTRY` macro to control code for LLVM JIT.
This was referenced Apr 15, 2024
|
LGTM |
|
LGTM |
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 1, 2024
Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 2, 2024
Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Enhance the GC subtyping checks: - Fix issues in the type equivalence check - Enable the recursive type subtyping check - Add a equivalence type flag in defined types of aot file, if there is an equivalence type before, just set it true and re-use the previous type - Normalize the defined types for interpreter and AOT - Enable spec test case type-equivalence.wast and type-subtyping.wast, and enable some commented cases - Enable set WAMR_BUILD_SANITIZER from cmake variable Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the GC subtyping checks:
equivalence type before, just set it true and re-use the previous type
and enable some commented cases