Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy _ProgramMap when RCU write. Fixes #45 #49

Merged
merged 1 commit into from
Jul 13, 2021
Merged

fix: copy _ProgramMap when RCU write. Fixes #45 #49

merged 1 commit into from
Jul 13, 2021

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Jul 12, 2021

  1. self memory copy at first when _ProgramMap.insert()
  2. add mux to avoid fieldCache racing when decoder.freezeFields()

@AsterDY
Copy link
Collaborator Author

AsterDY commented Jul 12, 2021 •
edited
Loading

Fixes issue #45. cc @bigfoot31

@AsterDY AsterDY changed the title fix: truely copy _ProgramMap when RCU write fix: copy _ProgramMap when RCU write Jul 12, 2021
@AsterDY AsterDY changed the title fix: copy _ProgramMap when RCU write fix: copy _ProgramMap when RCU write. Fixes #45 Jul 12, 2021
chenzhuoyu
chenzhuoyu approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@chenzhuoyu chenzhuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzhuoyu chenzhuoyu merged commit f519f80 into main Jul 13, 2021
@chenzhuoyu chenzhuoyu deleted the fix/RCU_copy branch July 13, 2021 17:31
@chenzhuoyu chenzhuoyu mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzhuoyu chenzhuoyu chenzhuoyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsterDY @chenzhuoyu