Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: try predict container size using SIMD #565

Closed
wants to merge 17 commits into from
Closed

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Dec 14, 2023

Background

  • JSON protocol doesn't write container size in message, thus container (array/object) growth consumes a lot of CPU (growslice+makemap+rehash) during deserializing.
  • We can try to scan json object or array ahead using SIMD to predict the size of the container

Draft

there are two methods:

  • count_elems: skip_one_fast for every elements in object/array, and count them -- the result is accurate as well as consuming a lot of CPU
  • count_elems_fast: skip_one_fast only for the entire container to obtain start and end, then scan and count number of comma , -- the result is inaccurate but very fast

below is benchmark result: (1~100 elements in a array)

goos: darwin
goarch: amd64
pkg: github.com/bytedance/sonic/internal/native/avx2
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkCountElems/1-16                    16.70 ns/op            0 B/op          0 allocs/op
BenchmarkCountElems/10-16                  122.5 ns/op             0 B/op          0 allocs/op
BenchmarkCountElems/100-16               1162 ns/op               0 B/op          0 allocs/op
BenchmarkCountElems_fast/1-16                19.29 ns/op            0 B/op          0 allocs/op
BenchmarkCountElems_fast/10-16             27.65 ns/op            0 B/op          0 allocs/op
BenchmarkCountElems_fast/100-16            71.72 ns/op            0 B/op          0 allocs/op

It seems only the count_elems_fast method is worthy for trading off container growth overhead

Experiment

use count_elems_fast() native func to scan and predict element size.

  • binding decoder
name                             old time/op    new time/op    delta
PredictContSize/map/N=0-16          119ns ±48%     103ns ±11%  -13.31%  (p=0.011 n=9+9)
PredictContSize/map/N=1-16          235ns ± 7%     251ns ± 2%   +6.78%  (p=0.000 n=9+8)
PredictContSize/map/N=10-16        1.22µs ±34%    0.72µs ± 4%  -40.70%  (p=0.000 n=10+9)
PredictContSize/map/N=100-16       10.0µs ± 7%     6.5µs ± 7%  -35.08%  (p=0.000 n=10+9)
PredictContSize/map/N=1000-16       120µs ±10%      65µs ± 3%  -45.96%  (p=0.000 n=10+9)
PredictContSize/slice/N=0-16       68.3ns ± 6%    69.7ns ± 1%     ~     (p=0.631 n=10+10)
PredictContSize/slice/N=1-16        107ns ± 4%     130ns ± 7%  +21.90%  (p=0.000 n=9+10)
PredictContSize/slice/N=10-16       328ns ± 1%     252ns ± 8%  -23.13%  (p=0.000 n=10+10)
PredictContSize/slice/N=100-16     1.90µs ± 2%    1.44µs ± 1%  -24.22%  (p=0.000 n=8+10)
PredictContSize/slice/N=1000-16    19.2µs ± 9%    14.6µs ± 6%  -24.02%  (p=0.000 n=10+10)

name                             old allocs/op  new allocs/op  delta
PredictContSize/map/N=0-16           2.00 ± 0%      2.00 ± 0%     ~     (all equal)
PredictContSize/map/N=1-16           3.00 ± 0%      3.00 ± 0%     ~     (all equal)
PredictContSize/map/N=10-16          4.00 ± 0%      3.00 ± 0%  -25.00%  (p=0.000 n=10+10)
PredictContSize/map/N=100-16         10.0 ± 0%       4.0 ± 0%  -60.00%  (p=0.000 n=10+10)
PredictContSize/map/N=1000-16        42.5 ± 1%       4.0 ± 0%  -90.59%  (p=0.000 n=10+10)
PredictContSize/slice/N=0-16         1.00 ± 0%      1.00 ± 0%     ~     (all equal)
PredictContSize/slice/N=1-16         2.00 ± 0%      2.00 ± 0%     ~     (all equal)
PredictContSize/slice/N=10-16        4.00 ± 0%      2.00 ± 0%  -50.00%  (p=0.000 n=10+10)
PredictContSize/slice/N=100-16       6.00 ± 0%      2.00 ± 0%  -66.67%  (p=0.000 n=10+10)
PredictContSize/slice/N=1000-16      8.00 ± 0%      2.00 ± 0%  -75.00%  (p=0.000 n=10+10)
  • generic decoder:
name                               old time/op    new time/op    delta
Generic_DecodeGeneric-16             81.3µs ± 0%    67.7µs ± 8%  -16.81%  (p=0.000 n=6+9)
Generic_Parallel_DecodeGeneric-16    25.6µs ±19%    29.1µs ±26%     ~     (p=0.063 n=10+10)

name                               old speed      new speed      delta
Generic_DecodeGeneric-16            160MB/s ± 0%   193MB/s ± 7%  +20.33%  (p=0.000 n=6+9)
Generic_Parallel_DecodeGeneric-16   515MB/s ±21%   459MB/s ±32%     ~     (p=0.063 n=10+10)

name                               old alloc/op   new alloc/op   delta
Generic_DecodeGeneric-16             48.9kB ± 0%    67.8kB ± 0%  +38.49%  (p=0.000 n=8+10)
Generic_Parallel_DecodeGeneric-16    49.0kB ± 0%    67.9kB ± 0%  +38.50%  (p=0.000 n=10+10)

name                               old allocs/op  new allocs/op  delta
Generic_DecodeGeneric-16                313 ± 0%       291 ± 0%   -7.03%  (p=0.000 n=10+10)

Conclusion

CPU performance improves +20~40% for container size > 10, in trading off Memory performance downgrades -40% (Malloc)

How to use

@AsterDY AsterDY marked this pull request as draft December 14, 2023 07:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (8c71eb0) 78.57% compared to head (80578e5) 77.62%.

Files Patch % Lines
internal/decoder/debug.go 0.00% 108 Missing ⚠️
internal/decoder/generic_regabi_amd64.go 25.00% 38 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   78.57%   77.62%   -0.95%     
==========================================
  Files          69       69              
  Lines       10714    10912     +198     
==========================================
+ Hits         8418     8470      +52     
- Misses       1930     2072     +142     
- Partials      366      370       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY AsterDY closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants