-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: try predict container size using SIMD #565
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 78.57% 77.62% -0.95%
==========================================
Files 69 69
Lines 10714 10912 +198
==========================================
+ Hits 8418 8470 +52
- Misses 1930 2072 +142
- Partials 366 370 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
growslice
+makemap
+rehash
) during deserializing.Draft
there are two methods:
count_elems
:skip_one_fast
for every elements in object/array, and count them -- the result is accurate as well as consuming a lot of CPUcount_elems_fast
:skip_one_fast
only for the entire container to obtain start and end, then scan and count number of comma,
-- the result is inaccurate but very fastbelow is benchmark result: (1~100 elements in a array)
It seems only the
count_elems_fast
method is worthy for trading off container growth overheadExperiment
use
count_elems_fast()
native func to scan and predict element size.Conclusion
CPU performance improves +20~40% for container size > 10, in trading off Memory performance downgrades -40% (Malloc)
How to use