fix:(ast) implement soft delete for Unset()
#571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ast.Node.Unset()
will hard delete child for one node. But since refactor:(ast) use linked chunk as fundamental storage for nodes #464 introduced llnked-chunk as storage, the behavior changed:Unset()
will set an empty node at the index but still count it. This inconsistency disturbs our users, although current behavior sounds more reasonable asUnset()
. Thus, we decide to be compatible with the old behavior.UnsetByIndex()
is not a behavior provided by stdslice
, we recommend users to useAdd()
andPop()
insteadFeature
Len()
andIndex()
won't count emtpy nodes, as implemenation ofsoft-delete
, which comes with overhead of index query O(N)Pop()
,Move()
API asslice-like
OP