Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance data race detection #651

Merged
merged 2 commits into from
Jun 24, 2024
Merged

test: enhance data race detection #651

merged 2 commits into from
Jun 24, 2024

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Jun 12, 2024

Enhance the data race detection when using Sonic JIT.

Problem: when running JIT codes, it will not generate race read/write even though enabling -race, and it will cause some data race cannot be detected.

Solution: We use encoding/json logic at first to make data race detection always work.

AsterDY
AsterDY previously approved these changes Jun 12, 2024
@liuq19 liuq19 force-pushed the fix/datarace branch 9 times, most recently from af157bd to a2fc197 Compare June 14, 2024 16:09
@liuq19 liuq19 marked this pull request as draft June 17, 2024 09:11
@liuq19 liuq19 marked this pull request as ready for review June 17, 2024 09:19
@AsterDY AsterDY merged commit f16c69f into main Jun 24, 2024
33 checks passed
@AsterDY AsterDY deleted the fix/datarace branch June 24, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants